ASP-based solver: allow configuring target selection#29835
Merged
becker33 merged 6 commits intospack:developfrom Apr 26, 2022
Merged
ASP-based solver: allow configuring target selection#29835becker33 merged 6 commits intospack:developfrom
becker33 merged 6 commits intospack:developfrom
Conversation
Member
Author
|
@bvanessen This is still a draft, but I think it might be one way to solve your issue with Spack reusing binaries that are incompatible with the host. Can you try this PR with: concretizer:
targets:
host_compatible: true? I drafted the PR after having observed an increase in the time it takes to concretize a spec if we add additional rules as in #29694. Since Spack seems sensitive to the number of targets that are used as candidates, here I simply avoid emitting facts for certain targets (i.e. I reduce the problem space) rather than having additional rules in the logic program. This is the result on my host:
when I concretize $ spack solve --timers hdf5
Time:
setup: 4.1003
load: 0.0191
ground: 1.3516
solve: 1.7280
Total: 7.2267
[ ... ]and when I only allow for generic $ spack solve --timers hdf5
Time:
setup: 3.9343
load: 0.0191
ground: 1.0835
solve: 1.4872
Total: 6.5506
[ ... ] |
Member
Author
|
Here's an example concretization when using: concretizer:
targets:
granularity: generic$ spack solve --timers trilinos |
becker33
reviewed
Apr 1, 2022
lib/spack/spack/solver/asp.py
Outdated
| if target not in compatible_targets: | ||
| compatible_targets.append(target) | ||
| if target not in candidate_targets: | ||
| candidate_targets.append(target) |
Member
There was a problem hiding this comment.
I think we need to add the ancestors of the target here as well. If I'm on an aarch64 system, and try to concretize hdf5 target=broadwell, then I should have haswell and x86_64 available as allbacks for dependency nodes that can't build with broadwell.
Member
Author
There was a problem hiding this comment.
See ec1bb5f I think we'll need to revisit anyhow when adding proper support for cross-compilation.
spackbot-app
bot
added
documentation
alalazo
force-pushed
the
features/target_selection
branch
from
16c4f88 to
4488a05
Compare
This commit adds a new "concretizer:targets" configuration section, and two options under it. - "concretizer:targets:granularity" allows switching from considering only generic targets to consider all possible microarchitectures. - "concretizer:targets:host_compatible" instead controls whether we can concretize for microarchitectures that are incompatible with the current host.
…gardless of settings)
alalazo
force-pushed
the
features/target_selection
branch
from
4488a05 to
2fbdc7b
Compare
alalazo
commented
Apr 25, 2022
becker33
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29672
This commit adds a new
concretizer:targetsconfiguration section, and two options under it.concretizer:targets:granularityallows switching from considering only generic targets to consider all possible microarchitectures.concretizer:targets:host_compatibleinstead controls whether we can concretize for microarchitectures that are incompatible with the current host.Modifications: