Hdf5 For Windows by jpopelar · Pull Request #29826 · spack/spack

jpopelar · 2022-03-31T22:21:56Z

Includes packaging for hdf5, bzip2, boost, pcre, openblas and sqlite. Also provides the WindowsPackage build system, which allows developers to specify shared, static, and static multithreaded runtime variants of packages.

This branch was rebased on top of develop moments ago so everything should be in order once tests pass

scheibelp

This is a preliminary review with some questions.

I think this could potentially be split into multiple PRs (e.g. the hdf5 changes are useful without the openblas changes), and that may be preferable if resolving all the questions here takes too much time.

var/spack/repos/builtin/packages/boost/package.py

lib/spack/spack/build_systems/python.py

lib/spack/llnl/util/filesystem.py

lib/spack/spack/compilers/msvc.py

lib/spack/spack/spec.py

var/spack/repos/builtin/packages/boost/package.py

var/spack/repos/builtin/packages/bzip2/package.py

scheibelp · 2022-04-04T23:26:48Z

var/spack/repos/builtin/packages/hdf5/package.py


-    depends_on('mpi', when='+mpi')
+    if sys.platform != 'win32':
+        depends_on('mpi', when='+mpi')


(question) to be clear, does this mean that building hdf5 with MPI support on Windows does not require any install of MPI on the system?

Ping - I would have assumed that building hdf5+mpi on Windows would require an MPI installation.

scheibelp · 2022-04-04T23:29:11Z

var/spack/repos/builtin/packages/hdf5/package.py

                # No try/except here, fix the condition above instead:
-                symlink('h5cc', 'h5pcc')
+                if sys.platform != 'win32':
+                    symlink('h5cc', 'h5pcc')


(question) #27021 added some logic for symlink analogs on Windows: does this still need to be skipped on Windows?

If so, the following if block also calls symlink and should also probably change in that case.

var/spack/repos/builtin/packages/openblas/package.py

…y need to go down CMake route

…ve towards adding logic for other options

…ork with MSVC, use -DTARGET=GENERIC for now

…sn't have a shared build recipe

…re packaging

…onflicts for upstream packages

alalazo · 2022-05-06T14:28:23Z

Would it be worth / possible to delay this until #30411 is in? That PR would allow to distinguish based on platform=windows in specs, rather than in-Python:

if is_windows:
    ...
else:
    ...

scheibelp · 2022-05-26T18:06:12Z

Close/reopen to restart tests

jpopelar · 2022-06-02T19:12:09Z

Test restart

This reverts commit 3d73ade, reversing changes made to d3bac4b.

jpopelar · 2022-06-15T15:04:06Z

Migrated to #31141 on fresh branch

spackbot-app bot added build-systems compilers conflicts dependencies libraries new-variant python update-package utilities labels Mar 31, 2022

This comment was marked as off-topic.

Sign in to view

scheibelp self-assigned this Mar 31, 2022

scheibelp reviewed Apr 4, 2022

View reviewed changes

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Apr 12, 2022

Addressing some code review suggestions from PR spack#29826

34a0338

spackbot-app bot added the documentation Improvements or additions to documentation label Apr 14, 2022

Jared Popelar added 16 commits April 15, 2022 08:03

Formatting

f1e56ee

Moving shared and staticmt builds into new WindowsPackage class

4f8bd8d

Formatting

5c43bc8

sqlite gotten past build stage, working on install

6a4479d

sqlite building and installing without readline

4d381a5

Saving progress, nmake doesn't work with GNU Makefiles, so will likel…

6e10476

…y need to go down CMake route

openblas building and installing with Bilder CMake arguments; will mo…

7cf8a84

…ve towards adding logic for other options

Following on OpenBLAS issue spack#2826 where -DDYNAMIC_ARCH doesn't w…

0abe560

…ork with MSVC, use -DTARGET=GENERIC for now

bzip2 packaged, needs to be built with ~shared since makefile.msc doe…

ca0d4db

…sn't have a shared build recipe

Setting shared default to false, phasing out Unix specific file upkeep

0349bee

Restoring default and conflict as per Greg Becker's suggestion

d424bf2

Formatting

40a97d3

Bringing over some of John Parent's bzip2 work, saving progress on pc…

6f03cad

…re packaging

Saving progress on boost and py-setuptools

7198d13

Fixing library extension on Windows

8b259a4

Setting default on bzip2 shared to be false on Windows; avoids spec c…

9ddb0d6

…onflicts for upstream packages

spackbot-app bot added the virtual-dependencies label May 5, 2022

Shouldn't be using CMakePackage

5aadc71

johnwparent and others added 2 commits May 11, 2022 12:50

Sanitize filepath from URL

cf8ec2a

Saving progress

63bb18c

This comment was marked as off-topic.

Sign in to view

scheibelp closed this May 26, 2022

scheibelp reopened this May 26, 2022

Fixing numpy conflict

7f82af4

spackbot-app bot added the stage label May 26, 2022

Jared Popelar added 2 commits May 26, 2022 19:59

Styling

2296c15

Adding dummy dlls for directory search tests

9db4418

jpopelar closed this Jun 2, 2022

jpopelar reopened this Jun 2, 2022

Jared Popelar and others added 3 commits June 6, 2022 08:29

Adding static libb.lib; search tests now passing

d3bac4b

Merge branch 'develop' into windows-hdf5

3d73ade

Revert "Merge branch 'develop' into windows-hdf5"

ce90453

This reverts commit 3d73ade, reversing changes made to d3bac4b.

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Jun 15, 2022

Addressing some code review suggestions from PR spack#29826

7302816

jpopelar mentioned this pull request Jun 15, 2022

Hdf5 For Windows V2 #31141

Merged

jpopelar closed this Jun 15, 2022

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Aug 9, 2022

Addressing some code review suggestions from PR spack#29826

110f9ac

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Aug 29, 2022

Addressing some code review suggestions from PR spack#29826

297b2b3

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Sep 7, 2022

Addressing some code review suggestions from PR spack#29826

92cef6d

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Sep 13, 2022

Addressing some code review suggestions from PR spack#29826

e5952f1

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Sep 23, 2022

Addressing some code review suggestions from PR spack#29826

0b852e7

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Sep 28, 2022

Addressing some code review suggestions from PR spack#29826

df3060f

jpopelar pushed a commit to Tech-XCorp/spack that referenced this pull request Nov 16, 2022

Addressing some code review suggestions from PR spack#29826

1c69727

Conversation

jpopelar commented Mar 31, 2022

Uh oh!

This comment was marked as off-topic.

scheibelp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scheibelp Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

scheibelp Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

scheibelp Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

scheibelp Apr 15, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alalazo commented May 6, 2022

Uh oh!

This comment was marked as off-topic.

scheibelp commented May 26, 2022

Uh oh!

jpopelar commented Jun 2, 2022

Uh oh!

jpopelar commented Jun 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants