Skip to content

hdf5: add v1.13.1 - experimental release.#29514

Merged
alalazo merged 2 commits intospack:developfrom
lrknox:hdf5-1.13.1
Mar 21, 2022
Merged

hdf5: add v1.13.1 - experimental release.#29514
alalazo merged 2 commits intospack:developfrom
lrknox:hdf5-1.13.1

Conversation

@lrknox
Copy link
Copy Markdown
Contributor

@lrknox lrknox commented Mar 15, 2022

No description provided.

@haampie
Copy link
Copy Markdown
Member

haampie commented Mar 15, 2022

@lrknox can you add preferred=True to all the versions listed under "maintenance versions" while you're at it?

@lrknox
Copy link
Copy Markdown
Contributor Author

lrknox commented Mar 15, 2022

@lrknox can you add preferred=True to all the versions listed under "maintenance versions" while you're at it?

I can, but I didn't realize that there could be more than one "preferred" version. Could you explain the effect of having multiple preferred versions?

@haampie
Copy link
Copy Markdown
Member

haampie commented Mar 15, 2022

I didn't either until recently. Spack takes from preferred versions first. So when version 14 comes out and you make it preferred, 13 is a development version, then some package conflicting with 14 should not default to 13, but rather pick the previous stable release. And that's done by preferring all stable versions.

@alalazo alalazo merged commit e485d16 into spack:develop Mar 21, 2022
@lrknox lrknox mentioned this pull request Aug 16, 2023
@lrknox
Copy link
Copy Markdown
Contributor Author

lrknox commented Dec 28, 2023

I didn't either until recently. Spack takes from preferred versions first. So when version 14 comes out and you make it preferred, 13 is a development version, then some package conflicting with 14 should not default to 13, but rather pick the previous stable release. And that's done by preferring all stable versions.

@haampie we made all stable versions preferred in PR #29514 when we added experimental release version 1.13.1. The 1.13.x versions were all removed after 1.14.0 (followed by 1.14.1, 1.14.2 and 1.14.3) were released. Do we no longer need more than one "preferred" version? Or at most one each for 1.14.x, 1.12.x, 1.10.x and 1.8.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants