Merged
Conversation
eugeneswalker
added
e4s
stand-alone-tests
vicentebolea
force-pushed
the
vtkm-update-smoke-test
branch
from
0e7f80a to
6450868
Compare
vicentebolea
force-pushed
the
vtkm-update-smoke-test
branch
3 times, most recently
from
e536942 to
592cf73
Compare
vicentebolea
force-pushed
the
vtkm-update-smoke-test
branch
from
592cf73 to
636e304
Compare
vicentebolea
force-pushed
the
vtkm-update-smoke-test
branch
from
636e304 to
40266fc
Compare
Member
Author
vicentebolea
dismissed stale reviews from kwryankrattiger and wspear
via
c01abda
vicentebolea
force-pushed
the
vtkm-update-smoke-test
branch
from
40266fc to
c01abda
Compare
kwryankrattiger
approved these changes
Jun 22, 2022
wspear
approved these changes
Jun 22, 2022
Contributor
wspear
left a comment
wspear
left a comment
There was a problem hiding this comment.
This works for me, even with a read-only install directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds a vtk-m spack smoke test:
It removes the currently existing ad-hoc build-test currently used, instead replaces it with the vtk-m built in smoke test. It also enables it as an Spack
smoke_testallowing to be run without rebuilding vtk-m by using the canonicalspack test run vtk-m