concretizer: make --reuse the default behavior#29111
Closed
concretizer: make --reuse the default behavior#29111
--reuse the default behavior#29111Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid repeated rebuilds in most cases, and to better enable users to use binaries out of the box, we want to switch to
--reuseas the default concretization behavior. This means that when users build, they'll build by default against a) things they already have installed and/or b) binary caches, where possible.That's a good default CLI behavior, but there are places where we do not want
--reuseto be the default -- namely CI. CI should be ensuring that the latest configuration continues to work properly, regardless of any state in the local installation or binary caches. I've changed the default for each of our CI environments here. I am debating whetherspack cishould just inherit settings from some common base config scope with "good" settings for CI. That is probably a future PR but it's worth thinking about. All our CI environments currently override a few things -- disabling the view, not doing reuse concretization, etc.This is draft for now, as we want to fix some outstanding bugs with
--reusefirst, and also merge #28504 at about the same time. See #24223 for more context.reusereuse: falsein all CI environments