add a path argument to the stage command#291
Merged
tgamblin merged 2 commits intospack:developfrom Mar 31, 2016
Merged
Conversation
Contributor
|
+1 I like this, but it needs a rebase. |
Member
|
@trws: sorry I didn't merge this. If you rebase we can add it. |
Allow users to use spack to stage a, potentially complex, package into a given path. This is nice for packages with multiple resources that must be placed, for example LLVM with all sub-projects.
This version actually pulls the path through the package to deliver it to each stage on creation when passed through the command. This is necessary due to the new StageComposite class that makes setting the path directly on the stage impractical, it also takes the logic out of package for the most part, which seems like an improvement.
Contributor
Author
|
It's rebased, and due to StageComposite somewhat reworked. Assuming it passes, which it seems to based on my local testing, glance over it and it should be good to go. |
Contributor
|
LGTM. |
matz-e
added a commit
to matz-e/spack
that referenced
this pull request
Apr 27, 2020
climbfuji
pushed a commit
to climbfuji/spack
that referenced
this pull request
Jul 14, 2023
Add MPI (MPI_Fint/mpi_comm_f2c) patch to scotch/parmetis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to use spack to stage a, potentially complex, package into a
given path. This is nice for packages with multiple resources that must
be placed, for example LLVM with all sub-projects.
This may not be the preferred way to do this, but seemed to be the least impact change.