py-pyqt5: add 5.15.6 and get sources from pypi#29039
py-pyqt5: add 5.15.6 and get sources from pypi#29039manuelakuhn wants to merge 4 commits intospack:developfrom
Conversation
spackbot-app
bot
added
build-systems
dependencies
new-version
python
update-package
labels
|
Hi @manuelakuhn! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers = ['manuelakuhn']If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame py-pyqt5Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
👀 |
Co-authored-by: Adam J. Stewart <[email protected]>
| with working_dir(self.stage.source_path): | ||
| sip = Executable(join_path(spec['py-sip'].prefix.bin, 'sip-install')) | ||
| sip(*self.build_args()) |
There was a problem hiding this comment.
Instead of using sip-install, is it possible to build with pip? Since sip is now a build-backend listed in pyproject.toml it should theoretically work with other Python build tools like pip and build.
Then, once the older versions are removed, we can directly subclass PythonPackage and delete SIPPackage entirely. I think we would have to deprecate py-pyqt4 first too. There's also a new py-pyqt6 package on PyPI.
Conversely, is it possible to build older versions with sip-install? What about py-pyqt4? Just trying to see if we can keep things uniform and/or reduce the number of build systems we support.
|
Ping @manuelakuhn |
|
sorry. totally forgot about this. I'll review it soon. |
|
Sorry for the delayed answer. I think there are some issues with this package now (doesn't build anymore) due to the age of this PR. I will have a look. |
|
I'm working on this in #32696 |
3 participants
General: at the moment
py-pyqt5does not build without #28870 (also before this PR).The build system has changed to
sip-installfor newer versions.Installs with
spack install --test=rootwithout problems for all 4 versions.Side note: The tarballs for versions <=5.13 are not available on the original sources anymore but only via the spack mirror.