Skip to content

Various package fixes for macOS#29024

Merged
sethrj merged 6 commits intospack:developfrom
sethrj:monterey-fixes
Feb 21, 2022
Merged

Various package fixes for macOS#29024
sethrj merged 6 commits intospack:developfrom
sethrj:monterey-fixes

Conversation

@sethrj
Copy link
Copy Markdown
Contributor

@sethrj sethrj commented Feb 17, 2022 •
edited
Loading

@sethrj sethrj requested a review from iarspider February 17, 2022 02:37
@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Feb 17, 2022

Hi @sethrj! I noticed that the following package(s) don't yet have maintainers:

  • libzmq

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['sethrj']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame libzmq

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@iarspider
Copy link
Copy Markdown
Contributor

iarspider commented Feb 17, 2022

@sethrj libzmq changes LGTM

@sethrj sethrj marked this pull request as ready for review February 17, 2022 14:27
iarspider
iarspider previously approved these changes Feb 17, 2022
View reviewed changes
alalazo
alalazo requested changes Feb 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor requests. Otherwise LGTM.

@alalazo alalazo self-assigned this Feb 18, 2022
@sethrj sethrj requested a review from alalazo February 18, 2022 12:04
alalazo
alalazo previously approved these changes Feb 18, 2022
View reviewed changes
@sethrj sethrj enabled auto-merge (squash) February 18, 2022 12:06
@sethrj
trilinos: disable dl on macOS
be37d2e
@sethrj
py-sphinx-argparse: add explicit poetry dependency
2c47adc
@sethrj
libzmq: fix libbsd dependency
2a4fd0e 
libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.
@sethrj
hdf5: work around GCC11.2 monterey fortran bug
7c9a7c0
@sethrj
go-bootstrap: mark conflict for monterey
40c5a6e
@sethrj
Copy link
Copy Markdown
Contributor Author

sethrj commented Feb 19, 2022

@alalazo I had to rebase to fix a conflict...

@sethrj sethrj requested a review from alalazo February 19, 2022 15:10
@sethrj sethrj merged commit 7459aa6 into spack:develop Feb 21, 2022
@sethrj sethrj deleted the monterey-fixes branch February 21, 2022 12:30
bvanessen pushed a commit to bvanessen/spack that referenced this pull request Mar 2, 2022
@sethrj @bvanessen
Various package fixes for macOS (spack#29024)
6cdb5e7 
* trilinos: disable dl on macOS

* py-sphinx-argparse: add explicit poetry dependency

* libzmq: fix libbsd dependency

libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.

* hdf5: work around GCC11.2 monterey fortran bug

* go-bootstrap: mark conflict for monterey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

@brtnfld brtnfld Awaiting requested review from brtnfld

@gheber gheber Awaiting requested review from gheber

@hyoklee hyoklee Awaiting requested review from hyoklee

@keitat keitat Awaiting requested review from keitat

@kuberry kuberry Awaiting requested review from kuberry

@lkurz lkurz Awaiting requested review from lkurz

@soumagne soumagne Awaiting requested review from soumagne

+1 more reviewer

@iarspider iarspider iarspider left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alalazo alalazo

Labels

conflicts dependencies new-variant patch python update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installation issue: go-bootstrap fails on monterey (x86_64)

3 participants

@sethrj @iarspider @alalazo