Conversation
|
@spackbot re-run pipeline |
|
I've started that pipeline for you! |
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
LGTM. I tested this on a number of packages using different url mechanisms and it provides the same outputs as the current processing on the system I usually use.
(It did alert me to a couple of packages with checksum issues for older versions (e.g., petsc, kafka). Not sure if it is worth correcting those older package versions.)
|
Deferring merge in case @adamjstewart wants to weigh in as well. |
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Why doesn't this fix #14129? Would adding a url_for_version to that specific package fix it?
|
It actually does fix that one also, I made a mistake when testing it, will fix the top post to close on merge. |
|
Seems the doc update broke the sphinx build. It's fixed and passing now but dismissed your review @adamjstewart. |
|
@spackbot re-run pipeline |
|
@spackbot re-run pipeline sigh |
|
I've started that pipeline for you! |
This is a minimal change toward getting the right archive from places like github. The heuristic is: * if an archive url exists, take its version * generate a url from the package with pkg.url_from_version * if they match * stop considering other URLs for this version * otherwise, continue replacing the url for the version I doubt this will always work, but it should address a variety of versions of this bug. A good test right now is `spack checksum gh`, which checksums macos binaries without this, and the correct source packages with it. fixes spack#15985 related to spack#14129 related to spack#13940
Since create can't rely on an existing package, this commit adds another pair of heuristics: 1. if the current version is a specifically listed archive, don't replace it 2. if the current url matches the result of applying `spack.url.substitute_version(a, ver)` for any a in archive_urls, prefer it and don't replace it fixes spack#13940
Co-authored-by: Adam J. Stewart <[email protected]>
|
Rebase to get a version where the e4s setup can build. Sorry to do this again @adamjstewart, but could you re-approve? |
* cmd/checksum: prefer url matching url_from_version This is a minimal change toward getting the right archive from places like github. The heuristic is: * if an archive url exists, take its version * generate a url from the package with pkg.url_from_version * if they match * stop considering other URLs for this version * otherwise, continue replacing the url for the version I doubt this will always work, but it should address a variety of versions of this bug. A good test right now is `spack checksum gh`, which checksums macos binaries without this, and the correct source packages with it. fixes spack#15985 related to spack#14129 related to spack#13940 * add heuristics to help create as well Since create can't rely on an existing package, this commit adds another pair of heuristics: 1. if the current version is a specifically listed archive, don't replace it 2. if the current url matches the result of applying `spack.url.substitute_version(a, ver)` for any a in archive_urls, prefer it and don't replace it fixes spack#13940 * clean up style and a lingering debug import * ok flake8, you got me * document reference_package argument * Update lib/spack/spack/util/web.py Co-authored-by: Adam J. Stewart <[email protected]> * try to appease sphinx Co-authored-by: Adam J. Stewart <[email protected]>
3 participants
This is a minimal change toward getting the right archive from places
like github in checksum and create. The heuristic is:
substitute_version
I doubt this will always work, but it should address a variety of
versions of this bug. A good test right now is
spack checksum gh,which checksums macos binaries without this, and the correct source
packages with it.
fixes #15985
fixes #14129
fixes #13940