Skip to content

Updates to add/remove conflicts for Apple silicon (M1/aarch64)#28850

Merged
sethrj merged 5 commits intospack:developfrom
sethrj:apple-silicon
Feb 19, 2022
Merged

Updates to add/remove conflicts for Apple silicon (M1/aarch64)#28850
sethrj merged 5 commits intospack:developfrom
sethrj:apple-silicon

Conversation

@sethrj
Copy link
Copy Markdown
Contributor

@sethrj sethrj commented Feb 9, 2022

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Feb 9, 2022

Hi @sethrj! I noticed that the following package(s) don't yet have maintainers:

  • go-bootstrap

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['sethrj']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame go-bootstrap

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@spackbot-app spackbot-app bot requested review from alecbcs, keitat and kuberry February 9, 2022 19:15
@sethrj
Copy link
Copy Markdown
Contributor Author

sethrj commented Feb 9, 2022

Thanks @becker33 for giving me the missing syntax!

@sethrj sethrj requested a review from becker33 February 9, 2022 23:25
Copy link
Copy Markdown
Member

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the audit error that's coming up right now. The conflict looks properly written to me, so maybe we have a bug there, but it's worth looking at.

@becker33
Copy link
Copy Markdown
Member

@sethrj can you rebase this on develop? The CI bugfix has been merged

@sethrj
Copy link
Copy Markdown
Contributor Author

sethrj commented Feb 10, 2022

@becker33 I thought I'd replied to your question but it seems not to be showing up:

It can't build from gcc languages=go?

GCC can't build yet on M1 (GCC12 is required but not yet released). The Homebrew GCC doesn't include golang support, and even then there are environment variables missing from the go build step that would be needed to work. This also triggered #28827 which tried to make my external GCC "automatically" gain go support even when it's missing.

@sethrj
Copy link
Copy Markdown
Contributor Author

sethrj commented Feb 11, 2022

ping @becker33

@sethrj
Copy link
Copy Markdown
Contributor Author

sethrj commented Feb 17, 2022

Ping @becker33

@becker33 becker33 dismissed their stale review February 18, 2022 00:54

outdated

@sethrj sethrj requested a review from trws February 18, 2022 00:55
@sethrj sethrj requested a review from trws February 18, 2022 12:11
@spackbot-app spackbot-app bot added the python label Feb 18, 2022
@sethrj sethrj enabled auto-merge (squash) February 18, 2022 21:06
@sethrj
Copy link
Copy Markdown
Contributor Author

sethrj commented Feb 18, 2022

Thanks for reviewing @trws !

@sethrj sethrj merged commit f337705 into spack:develop Feb 19, 2022
bvanessen pushed a commit to bvanessen/spack that referenced this pull request Mar 2, 2022
* go: remove broken bootstrapping for macos aarch64

* qt: mark apple silicon conflict

* trilinos: remove apple silicon conflict

* Apply review suggestions

* python: add apple silicon conflict for 2.7
@sethrj sethrj deleted the apple-silicon branch March 12, 2022 13:25
simo-tuomisto pushed a commit to AaltoSciComp/spack that referenced this pull request Jul 28, 2022
* go: remove broken bootstrapping for macos aarch64

* qt: mark apple silicon conflict

* trilinos: remove apple silicon conflict

* Apply review suggestions

* python: add apple silicon conflict for 2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants