Sarus: Use commits instead of sha 256 for correct version information#28705
Merged
haampie merged 4 commits intospack:developfrom Feb 1, 2022
Merged
Sarus: Use commits instead of sha 256 for correct version information#28705haampie merged 4 commits intospack:developfrom
haampie merged 4 commits intospack:developfrom
Conversation
- To retrieve the correct spack version we need to get it from the git repo. - Recommend installing the package with root for production - Add Tomas as maintainer to sarus' spack package
haampie
previously approved these changes
Feb 1, 2022
auto-merge was automatically disabled
February 1, 2022 14:17
Head branch was pushed to by a user without write access
- Improve post-install message
haampie
previously approved these changes
Feb 1, 2022
auto-merge was automatically disabled
February 1, 2022 14:43
Head branch was pushed to by a user without write access
haampie
approved these changes
Feb 1, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
- To retrieve the correct spack version we need to get it from the git repo. - Recommend installing the package with root for production - Add Tomas as maintainer to sarus' spack package - Add the option to disable unit tests in latest versions
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 8, 2022
- To retrieve the correct spack version we need to get it from the git repo. - Recommend installing the package with root for production - Add Tomas as maintainer to sarus' spack package - Add the option to disable unit tests in latest versions
EthanS94
pushed a commit
to EthanS94/spack
that referenced
this pull request
Feb 17, 2022
- To retrieve the correct spack version we need to get it from the git repo. - Recommend installing the package with root for production - Add Tomas as maintainer to sarus' spack package - Add the option to disable unit tests in latest versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--testin the newest version