Skip to content

ascent: add patch for gcc 10 + 11#28592

Merged
alalazo merged 3 commits intospack:developfrom
Alpine-DAV:task/2022_01_ascent_add_patch
Feb 1, 2022
Merged

ascent: add patch for gcc 10 + 11#28592
alalazo merged 3 commits intospack:developfrom
Alpine-DAV:task/2022_01_ascent_add_patch

Conversation

@cyrush
Copy link
Copy Markdown
Member

@cyrush cyrush commented Jan 25, 2022

No description provided.

@cyrush
Copy link
Copy Markdown
Member Author

cyrush commented Jan 25, 2022

@kwryankrattiger following up from Alpine-DAV/ascent#860, this patch should help with building 0.7.1

@cyrush cyrush requested a review from alalazo January 25, 2022 18:59
@cyrush
Copy link
Copy Markdown
Member Author

cyrush commented Jan 25, 2022

It looks like the style check is failing while installing prereqs for style check?

==> Error: cannot bootstrap any of the isort executables from spec "[email protected]: %gcc target=x86_64"

https://github.com/spack/spack/runs/4941780887?check_suite_focus=true#step:6:11

@kwryankrattiger
Copy link
Copy Markdown
Contributor

Two things I found.

  1. You have a space at the end of the patch in the package.py, so it can't be found.
  2. you need a space between the , and the when in the patch line

@cyrush
Copy link
Copy Markdown
Member Author

cyrush commented Jan 26, 2022

@kwryankrattiger thanks -- I fixed these typos.

@alalazo alalazo merged commit f5a70de into spack:develop Feb 1, 2022
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 1, 2022
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 8, 2022
EthanS94 pushed a commit to EthanS94/spack that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants