Skip to content

libzmq: add variants "docs", "libbsd"#28503

Merged
alalazo merged 8 commits intospack:developfrom
iarspider:libzmq-no-doc
Jan 23, 2022
Merged

libzmq: add variants "docs", "libbsd"#28503
alalazo merged 8 commits intospack:developfrom
iarspider:libzmq-no-doc

Conversation

@iarspider
Copy link
Copy Markdown
Contributor

@iarspider iarspider commented Jan 19, 2022

  • docs: whether to build and install documentation.
  • libbsd: whether to link with libbsd - libzmq will use own implementation of strlcpy if libbsd is not available.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jan 19, 2022

Hi @iarspider! I noticed that the following package(s) don't yet have maintainers:

  • libzmq

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['iarspider']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame libzmq

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@iarspider iarspider changed the title libzmq: add variant to disable building and installing documentation libzmq: add variants "docs", "libbsd" Jan 19, 2022
iarspider added a commit to iarspider/cms-spack-repo that referenced this pull request Jan 19, 2022
@alalazo alalazo self-assigned this Jan 19, 2022
alalazo
alalazo previously approved these changes Jan 19, 2022
@alalazo alalazo enabled auto-merge (squash) January 19, 2022 10:53
auto-merge was automatically disabled January 19, 2022 12:05

Head branch was pushed to by a user without write access

auto-merge was automatically disabled January 19, 2022 12:05

Head branch was pushed to by a user without write access

@iarspider iarspider requested a review from alalazo January 19, 2022 15:10
@iarspider
Copy link
Copy Markdown
Contributor Author

@spackbot re-run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jan 19, 2022

I've started that pipeline for you!

@iarspider
Copy link
Copy Markdown
Contributor Author

Not sure why it fails to build czmq - build fine locally

@iarspider
Copy link
Copy Markdown
Contributor Author

Random glitch probably.

@iarspider
Copy link
Copy Markdown
Contributor Author

@alalazo could you please merge this? Thanks!

@alalazo alalazo merged commit 7e5afd1 into spack:develop Jan 23, 2022
@iarspider iarspider deleted the libzmq-no-doc branch January 26, 2022 08:35
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 1, 2022
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 1, 2022
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 8, 2022
@sethrj
Copy link
Copy Markdown
Contributor

sethrj commented Feb 17, 2022

@iarspider I see that the libbsd variant shows up as requiring libbsd only on linux and cray platforms... do you know under what circumstances it's not required? It looks like prior to this commit, libbsd being "not found" (on my previous version bigsur macOS install) didn't cause an error. If you don't object I'm going to change to required for @4.3.3+ since that's when it seems to check for it -- and even if it's "found" it's probably coming from a system library.

@sethrj
Copy link
Copy Markdown
Contributor

sethrj commented Feb 17, 2022

I see the platform variation was from #20893 , not here... so I think the error is combination of that change and this one.

sethrj added a commit to sethrj/spack that referenced this pull request Feb 17, 2022
libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.
sethrj added a commit to sethrj/spack that referenced this pull request Feb 17, 2022
libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.
sethrj added a commit to sethrj/spack that referenced this pull request Feb 17, 2022
libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.
sethrj added a commit to sethrj/spack that referenced this pull request Feb 17, 2022
libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.
EthanS94 pushed a commit to EthanS94/spack that referenced this pull request Feb 17, 2022
sethrj added a commit to sethrj/spack that referenced this pull request Feb 19, 2022
libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.
sethrj added a commit to sethrj/spack that referenced this pull request Feb 19, 2022
libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.
sethrj added a commit that referenced this pull request Feb 21, 2022
* trilinos: disable dl on macOS

* py-sphinx-argparse: add explicit poetry dependency

* libzmq: fix libbsd dependency

libbsd is *always* required when +libbsd (introduced in #28503) . #20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.

* hdf5: work around GCC11.2 monterey fortran bug

* go-bootstrap: mark conflict for monterey
bvanessen pushed a commit to bvanessen/spack that referenced this pull request Mar 2, 2022
* trilinos: disable dl on macOS

* py-sphinx-argparse: add explicit poetry dependency

* libzmq: fix libbsd dependency

libbsd is *always* required when +libbsd (introduced in spack#28503) . spack#20893
had previously removed the macos dependency because libbsd wasn't always
enabled. Libbsd support is only available after 4.3.2 so change it to a
conflict rather than bumping the dependency.

* hdf5: work around GCC11.2 monterey fortran bug

* go-bootstrap: mark conflict for monterey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants