Python: add maintainers for Python 2#28386
Merged
adamjstewart merged 1 commit intospack:developfrom Jan 14, 2022
Merged
Conversation
|
@varioustoxins can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
scheibelp
approved these changes
Jan 12, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 8, 2022
EthanS94
pushed a commit
to EthanS94/spack
that referenced
this pull request
Feb 17, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds @scheibelp and @varioustoxins to the list of maintainers for our Python recipe. You'll likely get pinged on many issues/PRs related to Python. Feel free to ignore them unless they involve Python 2 or are a big change that is worth testing on Python 2. Although you're welcome to fix/review things related to Python 3 if you have time. Thanks for your help!
Once this is merged, I'll revert #28003. I'll likely still deprecate 3.1.5 just because we know it won't work once #28346 is merged (requires sysconfig which was added in 2.7/3.2). Other than that, I'm fine with keeping all other Python versions.