bootstrap: fix bootstrapping GnuPG from different macOS versions#28350
Merged
tgamblin merged 1 commit intospack:developfrom Jan 12, 2022
Merged
bootstrap: fix bootstrapping GnuPG from different macOS versions#28350tgamblin merged 1 commit intospack:developfrom
tgamblin merged 1 commit intospack:developfrom
Conversation
alalazo
added
bug
alalazo
force-pushed
the
fixes/macos_bootstrap_gnupg
branch
2 times, most recently
from
1fd4b6f to
c2bf6ea
Compare
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
alalazo
force-pushed
the
fixes/macos_bootstrap_gnupg
branch
from
63a123d to
19f1ada
Compare
tgamblin
approved these changes
Jan 12, 2022
pbrady
pushed a commit
to pbrady/spack
that referenced
this pull request
Jan 12, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
EthanS94
pushed a commit
to EthanS94/spack
that referenced
this pull request
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to changes in #27485, which introduced setting custom environment modifications for spec executables that are bootstrapped, using GnuPG on macOS versions which are different from the one in which it was built in CI stopped working.
The cause of the issue is that, to set variables at the
package.pymodule level we need a compiler entry compatible with the OS used to build GnuPG (in this caseCatalina). When run e.g. on a more recent OS, likeMontereywe have this error:This PR fixes the issue by explicitly avoid setting variables at the
package.pylevel during bootstrapping. With this modification the GnuPG executable built onCatalinaworks on any version of the OS > 10.13, including later versions: