Skip to content

libogg: patch stdint include, add v1.3.5#28332

Merged
alalazo merged 1 commit intospack:developfrom
nilsvu:packages/libogg
Jan 12, 2022
Merged

libogg: patch stdint include, add v1.3.5#28332
alalazo merged 1 commit intospack:developfrom
nilsvu:packages/libogg

Conversation

@nilsvu
Copy link
Copy Markdown
Contributor

@nilsvu nilsvu commented Jan 9, 2022

Installing libtheora failed on macOS 12.0.1 before this patch, at least with AppleClang 13 and with GCC 11.2.

If anyone knows details about when <sys/types.h> and <stdint.h> are available, please speak up :)

Edit: This is fixed upstream by xiph/ogg#64

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jan 9, 2022

Hi @nilsleiffischer! I noticed that the following package(s) don't yet have maintainers:

  • libogg

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['nilsleiffischer']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame libogg

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

alalazo
alalazo previously approved these changes Jan 11, 2022
@alalazo alalazo enabled auto-merge (squash) January 11, 2022 16:02
@nilsvu nilsvu changed the title libogg: patch stdint include libogg: patch stdint include, add v1.3.5 Jan 11, 2022
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jan 12, 2022

Can you rebase to run Gitlab pipelines on a new merge commit?

Backport a patch for v1.3.4 that fixes an unsigned typedef problem
on macOS: xiph/ogg#64

Also add v1.3.5 that has this issue fixed.
auto-merge was automatically disabled January 12, 2022 12:12

Head branch was pushed to by a user without write access

@alalazo alalazo enabled auto-merge (squash) January 12, 2022 12:33
@alalazo alalazo merged commit 38fee7e into spack:develop Jan 12, 2022
pbrady pushed a commit to pbrady/spack that referenced this pull request Jan 12, 2022
Backport a patch for v1.3.4 that fixes an unsigned typedef problem
on macOS: xiph/ogg#64

Also add v1.3.5 that has this issue fixed.
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 1, 2022
Backport a patch for v1.3.4 that fixes an unsigned typedef problem
on macOS: xiph/ogg#64

Also add v1.3.5 that has this issue fixed.
EthanS94 pushed a commit to EthanS94/spack that referenced this pull request Feb 17, 2022
Backport a patch for v1.3.4 that fixes an unsigned typedef problem
on macOS: xiph/ogg#64

Also add v1.3.5 that has this issue fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants