Hi @eschnett! I noticed that the following package(s) don't yet have maintainers:

• findutils

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['eschnett']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame findutils

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@spackbot run pipeline

I've started that pipeline for you!

Can you point to some bug report or description of the underlying issue? Technically iirc defining __ macro triggers UB, and what I wonder is what __nonnull is expected to return / be expanded to.

I opened a PR at #28356.

Can you rebase to run Gitlab pipelines on a new merge commit?

@spackbot run pipeline

I've started that pipeline for you!

@eschnett This patch seems to break the findutils build on my macOS. I am using spack commit c791ddc from Feb 7. My setup is macOS Monterey 12.1, running in Rosetta 2 x86_64 emulator mode, using [email protected] installed via homebrew. This is the error I got:

==> Installing findutils-4.7.0-h3fhihbyipvpkpyosc3v3bseblc4ak3s
==> No binary for findutils-4.7.0-h3fhihbyipvpkpyosc3v3bseblc4ak3s found: installing from source
/Users/heinzell/work/jedi-stack/spack-stack-new-joint/spack-stack-develop-20220209/spack/lib/spack/spack/target.py:137: UserWarning: microarchitecture specific optimizations are not supported yet on mixed compiler toolchains [check [email protected] for further details]
  warnings.warn(msg.format(compiler))
The text leading up to this was:
--------------------------
|--- a/gl/lib/malloc/dynarray-skeleton.c
|+++ b/gl/lib/malloc/dynarray-skeleton.c
--------------------------
File to patch:
Skip this patch? [y]
1 out of 1 hunk ignored
==> Fetching https://mirror.spack.io/_source-cache/archive/c5/c5fefbdf9858f7e4feb86f036e1247a54c79fc2d8e4b7064d5aaa1f47dfa789a.tar.xz
==> Patch /Users/heinzell/work/jedi-stack/spack-stack-new-joint/spack-stack-develop-20220209/spack/var/spack/repos/builtin/packages/findutils/nonnull.patch failed.
==> Error: ProcessError: Command exited with status 1:
    '/usr/bin/patch' '-s' '-p' '1' '-i' '/Users/heinzell/work/jedi-stack/spack-stack-new-joint/spack-stack-develop-20220209/spack/var/spack/repos/builtin/packages/findutils/nonnull.patch' '-d' '.'

Am I doing something wrong?

gl/lib/malloc does not exist in findutils < 4.8.0

gl/lib/malloc does not exist in findutils < 4.8.0

Thanks, @kgerheiser. I'll submit a bugfix PR later today.

I created an issue for this, and a PR to fix it: #28856 and #28857