grace: workaround for buffer overflows#28232
Merged
alalazo merged 1 commit intospack:developfrom Jan 12, 2022
Merged
Conversation
spack paths can be long and this overflows (at least) these buffers inside of the bundled T1lib inside of the grace distribution, leading to crashes on startup.
RemiLacroix-IDRIS
approved these changes
Jan 4, 2022
Contributor
RemiLacroix-IDRIS
left a comment
RemiLacroix-IDRIS
left a comment
There was a problem hiding this comment.
Looks good to me as far as I can tell.
alalazo
approved these changes
Jan 12, 2022
pbrady
pushed a commit
to pbrady/spack
that referenced
this pull request
Jan 12, 2022
spack paths can be long and this overflows (at least) these buffers inside of the bundled T1lib inside of the grace distribution, leading to crashes on startup.
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
spack paths can be long and this overflows (at least) these buffers inside of the bundled T1lib inside of the grace distribution, leading to crashes on startup.
EthanS94
pushed a commit
to EthanS94/spack
that referenced
this pull request
Feb 17, 2022
spack paths can be long and this overflows (at least) these buffers inside of the bundled T1lib inside of the grace distribution, leading to crashes on startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spack paths can be long and this overflows (at least) these buffers
inside of the bundled T1lib inside of the grace distribution, leading
to crashes on startup.