Provide meaningful message for empty environment installs#28031
Merged
tgamblin merged 2 commits intospack:developfrom Dec 16, 2021
Merged
Provide meaningful message for empty environment installs#28031tgamblin merged 2 commits intospack:developfrom
tgamblin merged 2 commits intospack:developfrom
Conversation
11 tasks
Contributor
Author
Contributor
Author
|
The test failure appears to be the spurious one described in #28021 . |
Contributor
Author
|
Force re-testing. |
tgamblin
approved these changes
Dec 16, 2021
haampie
pushed a commit
that referenced
this pull request
Dec 16, 2021
* Provide a meaningful failure message for installation of an empty environment * Allow regenerating view per offline discussion
alalazo
pushed a commit
that referenced
this pull request
Dec 23, 2021
* Provide a meaningful failure message for installation of an empty environment * Allow regenerating view per offline discussion
capitalaslash
pushed a commit
to capitalaslash/spack
that referenced
this pull request
Aug 30, 2022
* Provide a meaningful failure message for installation of an empty environment * Allow regenerating view per offline discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is the goal, but this PR provides a meaningful error message before terminating the
spack installof an empty environment. Without this change,with the change, a
an errormessage about no specs is output beforeterminatingcalling the code to regenerate the view:The reason for terminating is because we do that if no specs are provided on the command line. If that is not the desired behavior, this PR can be changed.