Bugfix: Simplify preferred-test versions; set checksum defaults#28026
Merged
alalazo merged 2 commits intospack:developfrom Dec 16, 2021
Merged
Bugfix: Simplify preferred-test versions; set checksum defaults#28026alalazo merged 2 commits intospack:developfrom
alalazo merged 2 commits intospack:developfrom
Conversation
tldahlgren
force-pushed
the
bugfix/test_checksum
branch
from
3d14712 to
bb2e4c3
Compare
alalazo
approved these changes
Dec 16, 2021
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Thanks for the quick response! Let's 🤞 and see if this improves CI error rates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28021 (hopefully)
This PR simplifies the
preferred-testmock package such that it leverages the repo of a relatively small, stable package with only one version. Doing so results in fewer fetches (1 versus many) during checksum testing, hopefully reducing the window for cleaning up the post-fetch stage directory.The PR also peripherally sets
checksumarguments to include defaults to be explicit.