VTK: Patch ADIOS2 module to fix cyclic dependency#27784
Merged
chuckatkins merged 1 commit intospack:developfrom Jan 5, 2022
Merged
VTK: Patch ADIOS2 module to fix cyclic dependency#27784chuckatkins merged 1 commit intospack:developfrom
chuckatkins merged 1 commit intospack:developfrom
Conversation
spackbot-app
bot
requested review from
chuckatkins,
danlipsa and
vicentebolea
kwryankrattiger
commented
Dec 8, 2021
Contributor
Author
kwryankrattiger
left a comment
kwryankrattiger
left a comment
There was a problem hiding this comment.
Also propagate mpi to adios
depends_on('adios2 +mpi', when='+adios2 +mpi')
depends_on('adios2 ~mpi', when='+adios2 ~mpi')
chuckatkins
reviewed
Dec 8, 2021
chuckatkins
reviewed
Dec 8, 2021
kwryankrattiger
force-pushed
the
patch_vtk_adios2
branch
2 times, most recently
from
97802d9 to
3ea74f3
Compare
kwryankrattiger
force-pushed
the
patch_vtk_adios2
branch
from
3ea74f3 to
b2415c3
Compare
chuckatkins
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chuckatkins
Ref.
https://gitlab.kitware.com/vtk/vtk/-/merge_requests/8653
After enabling the ADIOS2 option for paraview it was discovered that the IOADIOS2 module could not build with MPI. These patches fix that issue.
Tested building ParaView 5.8.1 and 5.9.0 and VTK 9.0.3 with gcc 9.3.0
Note, this patch was also applied to VTK even though there is not an ADIOS2 variant yet. The variant will be added later, including the patch here to keep this information in one place.
Note, these patches only includes changes to the
vtk.modulefile for IOADIOS2. The remaining changes from the MR in the VTK project are handled by not allowing+adios2when~mpi, this was done because the rest of the patch does not apply correctly. This should be fixed for ParaView 5.11.