Skip to content

spack audit: fix API calls to variants#27713

Merged
alalazo merged 1 commit intospack:developfrom
alalazo:bugfix/spack_audit
Nov 30, 2021
Merged

spack audit: fix API calls to variants#27713
alalazo merged 1 commit intospack:developfrom
alalazo:bugfix/spack_audit

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Nov 30, 2021

This broke in #24858 when package.variants became a tuple. Right now the command is unusable:

$ spack -d audit packages
==> [2021-11-30-10:05:03.813401] Imported audit from built-in commands
==> [2021-11-30-10:05:03.815805] Imported audit from built-in commands
==> [2021-11-30-10:05:03.816424] Reading config file /home/culpo/PycharmProjects/spack/etc/spack/defaults/repos.yaml
==> [2021-11-30-10:05:03.877291] Reading config file /home/culpo/PycharmProjects/spack/etc/spack/defaults/config.yaml
Traceback (most recent call last):
  File "/home/culpo/PycharmProjects/spack/bin/spack", line 98, in <module>
    sys.exit(spack.main.main())
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/main.py", line 882, in main
    return _main(argv)
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/main.py", line 865, in _main
    return _invoke_command(command, parser, args, unknown)
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/main.py", line 535, in _invoke_command
    return_val = command(parser, args)
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/cmd/audit.py", line 88, in audit
    subcommands[args.subcommand](parser, args)
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/cmd/audit.py", line 53, in packages
    reports = spack.audit.run_group(args.subcommand, pkgs=pkgs)
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/audit.py", line 141, in run_group
    errors = run_check(check, **kwargs)
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/audit.py", line 156, in run_check
    return CALLBACKS[tag].run(**kwargs)
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/audit.py", line 124, in run
    errors.extend(fn(**kwargs))
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/audit.py", line 330, in _unknown_variants_in_directives
    errors.extend(_analyze_variants_in_directive(
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/audit.py", line 422, in _analyze_variants_in_directive
    v.validate_or_raise(v, pkg=pkg)
  File "/home/culpo/PycharmProjects/spack/lib/spack/spack/variant.py", line 115, in validate_or_raise
    value = vspec.value
AttributeError: 'Variant' object has no attribute 'value'

@alalazo alalazo added commands bugfix Something wasn't working, here's a fix labels Nov 30, 2021
@alalazo alalazo requested a review from haampie November 30, 2021 09:14
@alalazo alalazo merged commit 645a7dc into spack:develop Nov 30, 2021
@alalazo alalazo deleted the bugfix/spack_audit branch November 30, 2021 13:59
haampie pushed a commit that referenced this pull request Nov 30, 2021
@haampie haampie mentioned this pull request Nov 30, 2021
24 tasks
alalazo added a commit that referenced this pull request Dec 23, 2021
capitalaslash pushed a commit to capitalaslash/spack that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants