[AMD][rocm-openmp-extras] - Updates for 4.3.1 and 4.5.0.#27653
[AMD][rocm-openmp-extras] - Updates for 4.3.1 and 4.5.0.#27653alalazo merged 3 commits intospack:developfrom
Conversation
estewart08
force-pushed
the
rocm-openmp-extras-4-5
branch
from
8f029db to
95fec0b
Compare
| # argument. This is fixed in later versions. | ||
| if self.spec.version == Version('4.3.0'): | ||
| if self.spec.version >= Version('4.3.0'): |
There was a problem hiding this comment.
If the strip is fixed in later versions, why is the check a greater than?
There was a problem hiding this comment.
Unfortunately, the small patch was not promoted to the release I originally thought. I expect this change to be in 5.0 and this condition will be updated once released.
|
Makes sense, but in that case should we keep the comment or maybe make it a TODO so it doesn’t get missed?
|
Changed comment to TODO. |
|
can we get this reviewed and if okay,merged ? |
| "13d3525078fd1c569f7c8ea7fce439b04f6b03814bbe88600c08f95c788e7802", | ||
| "13d3525078fd1c569f7c8ea7fce439b04f6b03814bbe88600c08f95c788e7802", |
There was a problem hiding this comment.
Is this correct that shas are the same?
There was a problem hiding this comment.
Yes, the sha (13d3525) stayed the same for 4.3.0 to 4.3.1. 4.5.0 updated to 3d7277fd6.
| "ec6cc4a9c24f098496de3206714dafe9a714f06afacfe21d53a4e6344f9cb4c9", | ||
| "ec6cc4a9c24f098496de3206714dafe9a714f06afacfe21d53a4e6344f9cb4c9", |
There was a problem hiding this comment.
Same answer as above. Sha stayed the same from 4.3.0 to 4.3.1.
4 participants
@haampie @srekolam @arjun-raj-kuppala