Merged
Conversation
added 13 commits
October 14, 2021 16:09
cmake installing and building the test.
spackbot-app
bot
added
new-version
stand-alone-tests
Contributor
At this point we've been asking people to simply print that the test is skipped. We've discussed pytest-like skip functionality but have not had the cycles to complete yet.
This is a known issue and the current approach is to print a skipped message. See answer to 1 for more. |
WeiqunZhang
previously approved these changes
Nov 16, 2021
Member
WeiqunZhang
left a comment
WeiqunZhang
left a comment
There was a problem hiding this comment.
LGTM. I tested it locally. It works as expected.
tldahlgren
requested changes
Nov 16, 2021
tldahlgren
requested changes
Nov 17, 2021
WeiqunZhang
approved these changes
Nov 21, 2021
Contributor
Author
|
I made the changes as requested. Thanks everyone for your input! |
ax3l
approved these changes
Jan 4, 2022
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Thanks for working on this @etpalmer63! 🎉
tldahlgren
approved these changes
Jan 12, 2022
Contributor
|
Force re-running checks due to |
auto-merge was automatically disabled
January 13, 2022 17:32
Pull request was closed
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
EthanS94
pushed a commit
to EthanS94/spack
that referenced
this pull request
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR puts in place a stand-alone test for AMReX. It is only compatible with the development branch at this point, however it will be supported on future releases of AMReX. I also had to implement the CMake workaround to ensure the same version that was used to install AMReX is used to compile the stand-alone test.
I have several concerns regarding skipping tests for past AMReX versions and would appreciate feedback on how to address them. They are:
spack test run amrexthe status is a reported as "PASSED". Is there a way to report a different status, such as "SKIPPED", etc. ?Thanks!
Erik