Skip to content

Fix overloaded argparse keys#27379

Merged
scheibelp merged 4 commits intospack:developfrom
haampie:fix/overloaded-env-arg
Nov 12, 2021
Merged

Fix overloaded argparse keys#27379
scheibelp merged 4 commits intospack:developfrom
haampie:fix/overloaded-env-arg

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Nov 12, 2021 •
edited
Loading

  • Fix overloaded env dest in argparse
  • Fix tests

Should fix the tests on python 3.9.x.

It's a bug on our side, but I guess we relied on this bug in python: python/cpython@a18d522

Note that this PR removes the unused argument in spack env loads [env] since that uses the active env only

@spackbot-app spackbot-app bot added commands tests General test capability(ies) labels Nov 12, 2021
@haampie haampie changed the title fix/overloaded env arg fix overloaded env arg Nov 12, 2021
@haampie haampie force-pushed the fix/overloaded-env-arg branch from ba28a31 to 0deee0c Compare November 12, 2021 01:24
@haampie haampie changed the title fix overloaded env arg Fix overloaded argparse keys Nov 12, 2021
@haampie haampie mentioned this pull request Nov 12, 2021
Closed
scheibelp
scheibelp approved these changes Nov 12, 2021
View reviewed changes
lib/spack/spack/reporters/cdash.py

def __init__(self, args):
Reporter.__init__(self, args)
tty.set_verbose(args.verbose)
Copy link
Copy Markdown
Member

@scheibelp scheibelp Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is the primary issue behind the failure in #27335 (https://github.com/spack/spack/runs/4181356619?check_suite_focus=true) (combined with your pointer to python/cpython@a18d522): i.e. the verbosity from main started overriding the verbosity setting on spack install.

@scheibelp
Copy link
Copy Markdown
Member

scheibelp commented Nov 12, 2021

@alalazo this looks like it will address the problems with #27335 (and all the other PRs. I need to step away but plan to come back and merge this when CI passes in a few hours.

@scheibelp scheibelp merged commit 9637ed0 into spack:develop Nov 12, 2021
scheibelp added a commit to alalazo/spack that referenced this pull request Nov 12, 2021
@scheibelp
Undo xfail
f651359 
This should now work with spack#27379 merged
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Nov 12, 2021

@haampie Thanks!

@haampie haampie deleted the fix/overloaded-env-arg branch November 12, 2021 10:44
@haampie
Copy link
Copy Markdown
Member Author

haampie commented Nov 12, 2021

This change made install -v more verbose than it was...

==> Processing libffi-3.3-k6kmrnkoic3atpszdgcfskf45oioytdx: task=priority=0, status=dequeued, start=0, #dependencies=0
==> libffi-3.3-k6kmrnkoic3atpszdgcfskf45oioytdx is now write locked
==> Removing build task for python-3.8.12-3q4nqw6ayex6gnm4vjuw43xv63zjzijx from list
==> Requeueing a build task for python-3.8.12-3q4nqw6ayex6gnm4vjuw43xv63zjzijx with status 'queued'
==> libffi-3.3-k6kmrnkoic3atpszdgcfskf45oioytdx is now read locked
[+] /home/user/spack/opt/spack/linux-ubuntu20.04-skylake/gcc-9.3.0/libffi-3.3-k6kmrnkoic3atpszdgcfskf45oioytdx

@haampie haampie mentioned this pull request Nov 12, 2021
Merged
haampie added a commit that referenced this pull request Nov 16, 2021
@haampie
Fix overloaded argparse keys (#27379)
6126275 
Commands should not reuse option names defined in main.
@haampie haampie mentioned this pull request Nov 16, 2021
Merged
24 tasks
alalazo pushed a commit that referenced this pull request Dec 23, 2021
@haampie @alalazo
Fix overloaded argparse keys (#27379)
d862507 
Commands should not reuse option names defined in main.
capitalaslash pushed a commit to capitalaslash/spack that referenced this pull request Aug 30, 2022
@haampie @capitalaslash
Fix overloaded argparse keys (spack#27379)
beceeae 
Commands should not reuse option names defined in main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scheibelp scheibelp scheibelp approved these changes

Assignees

No one assigned

Labels

commands tests General test capability(ies)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haampie @scheibelp @alalazo