Remove support for Python 2.6#27256
Merged
tgamblin merged 12 commits intospack:developfrom Nov 23, 2021
Merged
Conversation
spackbot-app
bot
added
binary-packages
commands
environments
tests
alalazo
force-pushed
the
maintainers/deprecate_python_26
branch
from
2a06543 to
f49d211
Compare
Member
|
We can also remove argparse |
Member
Author
|
I'm working through the dependencies. I think |
alalazo
force-pushed
the
maintainers/deprecate_python_26
branch
from
2dec531 to
0fecade
Compare
Member
Author
|
Since updating vendored dependencies is resulting in big changesets that might obfuscate the changes done in Core Spack, I'll submit separate PRs for those. |
This was referenced Nov 7, 2021
1 task
alalazo
force-pushed
the
maintainers/deprecate_python_26
branch
from
0fecade to
66586c5
Compare
These tests are done only to ensure support for Python 2.6. Removing them as a first step to remove support for Python 2.6 in Spack.
This backport was needed to support Python 2.6
This backport was needed to support Python 2.6
alalazo
force-pushed
the
maintainers/deprecate_python_26
branch
from
66586c5 to
3e42cb7
Compare
Member
|
Can you update the Getting Started docs too? |
Member
Author
|
@adamjstewart Should be done |
spackbot-app
bot
added
the
documentation
tgamblin
requested changes
Nov 22, 2021
Member
tgamblin
left a comment
tgamblin
left a comment
There was a problem hiding this comment.
One minor request in bin/spack
| ---------- | ||
|
|
||
| * Homepage: https://pypi.org/project/ordereddict/ | ||
| * Usage: A drop-in substitute for Py2.7's new collections.OrderedDict |
This was referenced Nov 23, 2021
Member
Author
|
@tgamblin @adamjstewart Ready for another review |
adamjstewart
approved these changes
Nov 23, 2021
tgamblin
approved these changes
Nov 23, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications:
centos:6unit test, adjusted vermin checkscollections.OrderedDictfunctools.total_orderingUpdating the vendored dependencies will be done in separate PRs