Skip to content

Fix the general case URL for the zlib tarball#2725

Closed
hartzell wants to merge 2 commits intodevelopfrom
bugfix/zlib-url
Closed

Fix the general case URL for the zlib tarball#2725
hartzell wants to merge 2 commits intodevelopfrom
bugfix/zlib-url

Conversation

@hartzell
Copy link
Copy Markdown
Contributor

@hartzell hartzell commented Jan 3, 2017

A recent pull request jiggled this around, but now it tries to download 1.2.10 from Canonical, which doesn't work.

@tgamblin -- I'm testing this now. Will follow up if/when it's ready to go.

hartzell and others added 2 commits January 3, 2017 14:17
@hartzell
Fix the general case URL for the zlib tarball
d6cd6c0 
A recent pull request jiggled this around, but now it tries to download 1.2.10 from Canonical, which doesn't work.

@tgamblin -- I'm testing this now.  Will follow up if/when it's ready to go.
Add a url_for method to handle old versions
201960c 
1.2.8 is not longer on the zlib site, but Canonical has it.

The first couple of tries at making old and new versions available
didn't work.  This does.

I can install [email protected] and [email protected].
@hartzell
Copy link
Copy Markdown
Contributor Author

hartzell commented Jan 3, 2017

@tgamblin -- this works for 1.2.8 and 1.2.10. Not sure that it's 'tasteful' however.

@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Jan 3, 2017

@tgamblin This looks like a major bug. I've never seen a version-specific url override a package-specific url for a different version.

@adamjstewart adamjstewart mentioned this pull request Jan 3, 2017
Closed
@adamjstewart adamjstewart added bug Something isn't working fetching labels Jan 3, 2017
@hartzell
Copy link
Copy Markdown
Contributor Author

hartzell commented Jan 3, 2017

By way of documentation (he's from Missouri, you have to show him...):

==> Installing zlib
curl: (22) The requested URL returned error: 404 Not Found
==> Fetching http://pkgs.fedoraproject.org/repo/pkgs/mingw-zlib/zlib-1.2.10.tar.gz/44d667c142d7cda120332623eab69f40/zlib-1.2.10.tar.gz
==> Fetching from http://pkgs.fedoraproject.org/repo/pkgs/mingw-zlib/zlib-1.2.10.tar.gz/44d667c142d7cda120332623eab69f40/zlib-1.2.10.tar.gz failed.
==> Error: FetchError: All fetchers failed for zlib-1.2.10-rwkggjpl7lc44azepv6khazzdds3dfbs
Build step 'Execute shell' marked build as failure

@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Jan 3, 2017

You can also see what URLs Spack will use by running:

$ spack info zlib
...
    1.2.10    http://pkgs.fedoraproject.org/repo/pkgs/mingw-zlib/zlib-1.2.10.tar.gz/44d667c142d7cda120332623eab69f40/zlib-1.2.10.tar.gz
    1.2.8     http://pkgs.fedoraproject.org/repo/pkgs/mingw-zlib/zlib-1.2.8.tar.gz/44d667c142d7cda120332623eab69f40/zlib-1.2.8.tar.gz

Btw, I'm not seeing this with other packages:

$ spack info py-scipy
...
    0.18.1    https://pypi.python.org/packages/22/41/b1538a75309ae4913cdbbdc8d1cc54cae6d37981d2759532c1aa37a41121/scipy-0.18.1.tar.gz
    0.17.0    https://pypi.python.org/packages/source/s/scipy/scipy-0.17.0.tar.gz
    0.15.1    https://pypi.python.org/packages/source/s/scipy/scipy-0.15.1.tar.gz
    0.15.0    https://pypi.python.org/packages/source/s/scipy/scipy-0.15.0.tar.gz

@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Jan 3, 2017

More debugging info. If you hack py-scipy to look like:

    version('0.19.0', 'fake-version-and-hash-0123456789')                                               
    version('0.18.1', '5fb5fb7ccb113ab3a039702b6c2f3327',                       
            url="https://pypi.python.org/packages/22/41/b1538a75309ae4913cdbbdc8d1cc54cae6d37981d2759532c1aa37a41121/scipy-0.18.1.tar.gz")
    version('0.17.0', '5ff2971e1ce90e762c59d2cd84837224')                       
    version('0.15.1', 'be56cd8e60591d6332aac792a5880110')                       
    version('0.15.0', '639112f077f0aeb6d80718dc5019dc7a')

you can reproduce this bug:

$ spack info py-scipy
...
    0.19.0    https://pypi.python.org/packages/22/41/b1538a75309ae4913cdbbdc8d1cc54cae6d37981d2759532c1aa37a41121/scipy-0.19.0.tar.gz
    0.18.1    https://pypi.python.org/packages/22/41/b1538a75309ae4913cdbbdc8d1cc54cae6d37981d2759532c1aa37a41121/scipy-0.18.1.tar.gz
    0.17.0    https://pypi.python.org/packages/source/s/scipy/scipy-0.17.0.tar.gz
    0.15.1    https://pypi.python.org/packages/source/s/scipy/scipy-0.15.1.tar.gz
    0.15.0    https://pypi.python.org/packages/source/s/scipy/scipy-0.15.0.tar.gz

@hartzell
Copy link
Copy Markdown
Contributor Author

hartzell commented Jan 3, 2017

I'm out of my depth....

@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Jan 3, 2017

Btw, reordering:

    version('1.2.10', 'd9794246f853d15ce0fcbf79b9a3cf13')   
    version('1.2.8', '44d667c142d7cda120332623eab69f40',                        
            url='http://pkgs.fedoraproject.org/repo/pkgs/mingw-zlib/zlib-1.2.8.tar.gz/44d667c142d7cda120332623eab69f40/zlib-1.2.8.tar.gz'
           )

as:

    version('1.2.8', '44d667c142d7cda120332623eab69f40',                        
            url='http://pkgs.fedoraproject.org/repo/pkgs/mingw-zlib/zlib-1.2.8.tar.gz/44d667c142d7cda120332623eab69f40/zlib-1.2.8.tar.gz'
           )                                                                    
    version('1.2.10', 'd9794246f853d15ce0fcbf79b9a3cf13')

doesn't help.

adamjstewart
adamjstewart approved these changes Jan 3, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a perfectly fine hack for now, but we really need to get to the bottom of this bug.

@hartzell
Copy link
Copy Markdown
Contributor Author

hartzell commented Jan 3, 2017

a perfectly fine hack for now

That's a perfect saying for either

  • a business card
  • a tombstone

:)

@citibeth
Copy link
Copy Markdown
Member

citibeth commented Jan 3, 2017

I'm wondering if this is related to the impenetrable FetchStrategy code.

@citibeth
Copy link
Copy Markdown
Member

citibeth commented Jan 4, 2017

I think we need to have the general class-wide URL set to the fossils directory, and the latest-version URL specially set for the non-fossil directory. Is it OK to close this PR?

@citibeth citibeth closed this Jan 4, 2017
@hartzell hartzell deleted the bugfix/zlib-url branch January 4, 2017 16:26
@hartzell
Copy link
Copy Markdown
Contributor Author

hartzell commented Jan 4, 2017

Yes, close it (I see that you already have...).

In the ongoing search for a local minima for the zlib package, #2735 uses the zlib fossil site....

@adamjstewart adamjstewart mentioned this pull request Jan 4, 2017
Merged
adamjstewart referenced this pull request Jan 4, 2017
@BarrySmith @tgamblin
Update to latest zlib version, server no longer provides older version (
2322ded 
#2720)

* Update to latest zlib version, server no longer provides older version

Funded-by: IDEAS
Project: IDEAS/xSDK

* Add alternative URL for previous release of zlib
@adamjstewart adamjstewart mentioned this pull request Jan 4, 2017
Closed
@adamjstewart adamjstewart mentioned this pull request Feb 20, 2017
Merged
@hartzell hartzell mentioned this pull request May 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees

No one assigned

Labels

bug Something isn't working fetching

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hartzell @adamjstewart @citibeth