mfem, hpx: fix recipes after conditional variants#27215
Merged
alalazo merged 2 commits intospack:developfrom Nov 4, 2021
Merged
mfem, hpx: fix recipes after conditional variants#27215alalazo merged 2 commits intospack:developfrom
alalazo merged 2 commits intospack:developfrom
Conversation
spackbot-app
bot
requested review from
acfisher,
albestro,
goxberry,
markcmiller86,
msimberg,
tzanio and
v-dobrev
alalazo
removed request for
acfisher,
goxberry,
markcmiller86,
msimberg,
tzanio and
v-dobrev
|
@teonnik can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
eugeneswalker
approved these changes
Nov 4, 2021
teonnik
approved these changes
Nov 4, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #27213
The
variantsattribute of package objects was changed to allow for conditional variants. While a better API can be thought of (as correctly noted in #27185 (comment)), the recipes reading it directly are just a handful so here I'm fixing them without introducing core changes.