Update to latest zlib version, server no longer provides older version#2720
Merged
Update to latest zlib version, server no longer provides older version#2720
Conversation
Funded-by: IDEAS Project: IDEAS/xSDK
citibeth
reviewed
Jan 3, 2017
| url = "http://zlib.net/zlib-1.2.8.tar.gz" | ||
|
|
||
| version('1.2.10', 'd9794246f853d15ce0fcbf79b9a3cf13') | ||
| version('1.2.8', '44d667c142d7cda120332623eab69f40') |
Member
There was a problem hiding this comment.
Could you please change the old line to:
version('1.2.8', '44d667c142d7cda120332623eab69f40',
url='http://pkgs.fedoraproject.org/repo/pkgs/mingw-zlib/zlib-1.2.8.tar.gz/44d667c142d7cda120332623eab69f40/zlib-1.2.8.tar.gz')
This will ensure that the old version still works, even though it's been removed from the zlib website. And because the tarball from Fedora has the same checksum (I checked it), we know it's the same that we've been working with all along.
adamjstewart
approved these changes
Jan 3, 2017
Contributor
Author
|
updated |
Closed
Contributor
|
Building [email protected] is broken, pending this fix. |
Member
|
Ping @tgamblin |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Funded-by: IDEAS
Project: IDEAS/xSDK