commands: spack load --list alias for spack find --loaded#27184
Merged
commands: spack load --list alias for spack find --loaded#27184
spack load --list alias for spack find --loaded#27184Conversation
tgamblin
requested review from
RikkiButler20,
adamjstewart,
mwkrentel and
tldahlgren
spackbot-app
bot
added
commands
documentation
See #25249 and #27159 (comment). This adds `spack load --list` as an alias for `spack find --loaded`. The new command is not as powerful as `spack find --loaded`, as you can't combine it with all the queries or formats that `spack find` provides. However, it is more intuitively located in the command structure in that it appears in the output of `spack load --help`. The idea here is that people can use `spack load --list` for simple stuff but fall back to `spack find --loaded` if they need more. - [x] add help to `spack load --list` that references `spack find` - [x] factor some parts of `spack find` out to be called from `spack load` - [x] add shell integration - [x] add shell test - [x] update completion - [x] update docs
tgamblin
force-pushed
the
spack-load-list
branch
from
dbddfae to
b624c5b
Compare
adamjstewart
previously approved these changes
Nov 3, 2021
scheibelp
dismissed stale reviews from adamjstewart and mwkrentel
via
70708d7
RikkiButler20
requested changes
Nov 4, 2021
RikkiButler20
requested changes
Nov 4, 2021
Co-authored-by: Richarda Butler <[email protected]>
tldahlgren
requested changes
Nov 5, 2021
tldahlgren
previously approved these changes
Nov 5, 2021
scheibelp
approved these changes
Nov 5, 2021
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
(Prior review was approval and the only changes since are for style checks)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #25249 and #27159 (comment).
This adds
spack load --listas an alias forspack find --loaded. The new command isnot as powerful as
spack find --loaded, as you can't combine it with all the queries orformats that
spack findprovides. However, it is more intuitively located in the commandstructure in that it appears in the output of
spack load --help.The idea here is that people can use
spack load --listfor simple stuff but fall back tospack find --loadedif they need more.spack load --listthat referencesspack findspack findout to be called fromspack load