Skip to content

py-neurokit2: add 0.1.4.1#26871

Merged
adamjstewart merged 2 commits intospack:developfrom
manuelakuhn:py-neurokit2-0.1.4.1
Oct 21, 2021
Merged

py-neurokit2: add 0.1.4.1#26871
adamjstewart merged 2 commits intospack:developfrom
manuelakuhn:py-neurokit2-0.1.4.1

Conversation

@manuelakuhn
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a missing build dep:

depends_on('py-pytest-runner', type='build')

@manuelakuhn
Copy link
Copy Markdown
Member Author

Just checked again and installing with spack install --test=root py-neurokit2, loading and running the quick example all work without this dependency. Should I add it, nevertheless?

@adamjstewart
Copy link
Copy Markdown
Member

Yeah, you should still add it. If it's not already installed, setuptools will automatically download and install it, which won't work on air-gapped networks.

@adamjstewart adamjstewart enabled auto-merge (squash) October 21, 2021 20:04
@adamjstewart adamjstewart merged commit dbe1060 into spack:develop Oct 21, 2021
@manuelakuhn manuelakuhn deleted the py-neurokit2-0.1.4.1 branch October 21, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants