Skip to content

py-sfepy: update to v2021.3#26865

Merged
adamjstewart merged 1 commit intospack:developfrom
rc:update-sfepy
Oct 21, 2021
Merged

py-sfepy: update to v2021.3#26865
adamjstewart merged 1 commit intospack:developfrom
rc:update-sfepy

Conversation

@rc
Copy link
Copy Markdown
Contributor

@rc rc commented Oct 21, 2021

No description provided.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Oct 21, 2021

@adamjstewart Wondering why spackbot didn't run on this PR 🤔

@rc
Copy link
Copy Markdown
Contributor Author

rc commented Oct 21, 2021

@adamjstewart Wondering why spackbot didn't run on this PR thinking

I disabled github actions on my fork, to prevent running all the checks for every commit prior to the PR. Might that be related?

@rc
Copy link
Copy Markdown
Contributor Author

rc commented Oct 21, 2021

I have just fixed the tarball url...

url = "https://github.com/sfepy/sfepy/archive/release_2021.3.tar.gz"

version('2017.3', sha256='d13642b7abed63b83b7eaef4dfce6e84a5afc5798bc7ffa1c413e3e44b5e5996')
version('2021.3', sha256='822407595e0af5aeaca6ca50e88e46658b5021e177244cbb763dd260e94eda81')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spack's policy is not to remove old versions without first deprecating them to give users time to migrate to the new release, see https://spack.readthedocs.io/en/latest/packaging_guide.html#deprecating-old-versions

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out - I also tried to make the new dependencies conditional based on the version. Conditional variants are not available yet, right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, although you can add conflicts that prevent a variant from being used for older versions. I think @becker33 was working on conditional variants?

@adamjstewart adamjstewart enabled auto-merge (squash) October 21, 2021 20:52
@adamjstewart adamjstewart merged commit 9b28f99 into spack:develop Oct 21, 2021
@rc rc deleted the update-sfepy branch October 22, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants