Skip to content

Command Line Scopes#2686

Closed
citibeth wants to merge 7 commits intospack:developfrom
citibeth:efischer/161229-CmdLineScopes
Closed

Command Line Scopes#2686
citibeth wants to merge 7 commits intospack:developfrom
citibeth:efischer/161229-CmdLineScopes

Conversation

@citibeth
Copy link
Copy Markdown
Member

@citibeth citibeth commented Dec 30, 2016

Allows the user to add additional configuration scopes (beyond defaults/site/user) on the command line for all Spack commands. Docs are included in the PR, should be self-explanatory. I did this because I need it.

This addresses #2171, and gets a lot of functionality for a small number of lines of changed code.

@citibeth citibeth added configuration feature A feature is missing in Spack labels Dec 30, 2016
Elizabeth Fischer added 2 commits December 30, 2016 17:23
@citibeth citibeth added the ready label Dec 30, 2016
@citibeth
Copy link
Copy Markdown
Member Author

Note... this needs #2694 to be useful in real life.

@citibeth
Copy link
Copy Markdown
Member Author

Does anyone have thoughts on this? I think it's a lot more interesting than #2705

@tgamblin
Copy link
Copy Markdown
Member

I plan to look at this in the environments WG and after 0.10 but in general I think it's a good idea.

@mwkrentel
Copy link
Copy Markdown
Member

I wrote a similar patch for this in PR #6903 in Jan 2018, except that
I did the early option parsing in init.py directly from sys.argv[].

So, now I'm embarrassed that I didn't search the old PRs sufficiently.
(I think I searched for 'config' rather than 'scope'.)

Anyway, I'm confident that you know more about spack than I do and
your patch is exactly what I want. So, I'll bow out and close mine as
a duplicate.

Thanks, and be sure to nag Todd until his patch is committed.

@citibeth
Copy link
Copy Markdown
Member Author

@mwkrentel This functionality has now been incorporated as part of the larger Spack Environments project. I encourage you to take a gander at #7843 and try it out; I am currently building my software stack based on that PR.

In the meantime, I'm closing this PR: stacked scopes inside the Spack Environment are just nicer in so many ways that stacking them on the command line.

@citibeth citibeth closed this Apr 26, 2018
@tgamblin tgamblin mentioned this pull request Jun 24, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration feature A feature is missing in Spack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants