Propagate +adios2 to paraview for Data and Vis SDK#26747
Propagate +adios2 to paraview for Data and Vis SDK#26747chuckatkins merged 1 commit intospack:developfrom
Conversation
|
@kwryankrattiger looks like a good refactor, few things:
|
Data and Visualization, @chuckatkins recommended the acronym for use in the SDK package.
There is one by me that is the main refactor the rest of them are from a rebase onto |
f614acc to
19b8f93
Compare
|
+1 after fixing style check |
66491a7 to
0ebccdf
Compare
|
@spackbot run pipeline |
|
I had a problem triggering the pipeline. |
|
@spackbot run pipeline |
|
I had a problem triggering the pipeline. |
|
The I think that was fixed in 1dcabdbc8d, in which case this PR needs a rebase. |
Head branch was pushed to by a user without write access
5e2e6ed
0ebccdf to
5e2e6ed
Compare
5e2e6ed to
3042069
Compare
|
@adamjstewart Did you intend to block this merge? This is ready now after rebasing on #27784 merged which fixed enabling ADIOS2 with ParaView. |
|
Hmm, I don't remember dismissing @chuckatkins review. Usually when I do this it's because someone requested changes and the changes were added but the person never re-reviewed. Reviews also get dismissed when you rebase, maybe that's what happened? Anyway, no problems with this being merged from my side. |
Depends on #26728 and #26175
@chuckatkins