Skip to content

Propagate +adios2 to paraview for Data and Vis SDK#26747

Merged
chuckatkins merged 1 commit intospack:developfrom
kwryankrattiger:dav_paraview+adios2
Jan 12, 2022
Merged

Propagate +adios2 to paraview for Data and Vis SDK#26747
chuckatkins merged 1 commit intospack:developfrom
kwryankrattiger:dav_paraview+adios2

Conversation

@kwryankrattiger
Copy link
Copy Markdown
Contributor

Depends on #26728 and #26175

@chuckatkins

@vicentebolea
Copy link
Copy Markdown
Member

@kwryankrattiger looks like a good refactor, few things:

  • What does DAV stands for?
  • How about making a more verbose PR description
  • It seems to be rebased on the top of other contributions, are those from the PR referenced in the description of this issue?

@kwryankrattiger
Copy link
Copy Markdown
Contributor Author

@vicentebolea

* What does DAV stands for?

Data and Visualization, @chuckatkins recommended the acronym for use in the SDK package.

* It seems to be rebased on the top of other contributions, are those from the PR referenced in the description of this issue?

There is one by me that is the main refactor the rest of them are from a rebase onto spack/develop, I think I may have rebased things in the wrong order, I will re-propagate all of the rebases for this branch.

@kwryankrattiger kwryankrattiger changed the title Dav paraview+adios2 Propagate +adios2 to paraview for Data and Vis SDK Oct 19, 2021
@kwryankrattiger kwryankrattiger force-pushed the dav_paraview+adios2 branch 2 times, most recently from f614acc to 19b8f93 Compare October 20, 2021 16:50
vicentebolea
vicentebolea previously approved these changes Oct 21, 2021
Copy link
Copy Markdown
Member

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vicentebolea
Copy link
Copy Markdown
Member

+1 after fixing style check

chuckatkins
chuckatkins previously approved these changes Nov 4, 2021
@chuckatkins chuckatkins enabled auto-merge (squash) November 4, 2021 00:13
vicentebolea
vicentebolea previously approved these changes Nov 4, 2021
@haampie
Copy link
Copy Markdown
Member

haampie commented Nov 9, 2021

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Nov 9, 2021

I had a problem triggering the pipeline.

@kwryankrattiger
Copy link
Copy Markdown
Contributor Author

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Nov 10, 2021

I had a problem triggering the pipeline.

@scottwittenburg
Copy link
Copy Markdown
Contributor

The hpx package failed on gitlab with:

/builds/spack/spack/var/spack/repos/builtin/packages/hpx/package.py:166, in instrumentation_args:
        165    def instrumentation_args(self):
  >>    166        for value in self.variants['instrumentation'].values:
        167            if value == 'none':
        168                continue
        169

I think that was fixed in 1dcabdbc8d, in which case this PR needs a rebase.

auto-merge was automatically disabled November 10, 2021 18:11

Head branch was pushed to by a user without write access

@chuckatkins chuckatkins enabled auto-merge (squash) January 5, 2022 16:57
chuckatkins
chuckatkins previously approved these changes Jan 5, 2022
@kwryankrattiger
Copy link
Copy Markdown
Contributor Author

@adamjstewart Did you intend to block this merge? This is ready now after rebasing on #27784 merged which fixed enabling ADIOS2 with ParaView.

@adamjstewart
Copy link
Copy Markdown
Member

Hmm, I don't remember dismissing @chuckatkins review. Usually when I do this it's because someone requested changes and the changes were added but the person never re-reviewed. Reviews also get dismissed when you rebase, maybe that's what happened? Anyway, no problems with this being merged from my side.

@chuckatkins chuckatkins merged commit 6c9b781 into spack:develop Jan 12, 2022
pbrady pushed a commit to pbrady/spack that referenced this pull request Jan 12, 2022
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 1, 2022
EthanS94 pushed a commit to EthanS94/spack that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants