scr/veloc: component releases by CamStan · Pull Request #26716 · spack/spack

CamStan · 2021-10-13T17:00:11Z

Update the ECP-VeloC component packages in preparation for an
upcoming [email protected] release.

All

Add new release versions
Add new shared variant for all components
Add zlib link dependency to packages that were missing it

axl

Add independent vendor async support variants

rankstr

Update older version sha that fails checksum on install

Update

All

Add maintainers
Use self.define and self.define_from_variant to clean up cmake_args

spackbot-app · 2021-10-13T17:00:18Z

Hi @CamStan! I noticed that the following package(s) don't yet have maintainers:

axl
er
kvtree
rankstr
redset
shuffile
spath

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['CamStan']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame axl

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

CamStan · 2021-10-13T17:13:02Z

I can add myself as a maintainer.

tldahlgren

Confirmed all of the new sha256 values.

Recommend using CMakePackage's self.define_from_variant.

var/spack/repos/builtin/packages/axl/package.py

var/spack/repos/builtin/packages/er/package.py

var/spack/repos/builtin/packages/kvtree/package.py

Update the ECP-VeloC component packages in preparation for an upcoming [email protected] release. All - Add new release versions - Add new `shared` variant for all components - Add zlib link dependency to packages that were missing it - Add maintainers - Use self.define and self.define_from_variant to clean up cmake_args axl - Add independent vendor async support variants rankstr - Update older version sha that fails checksum on install

CamStan · 2021-10-15T19:10:06Z

@tldahlgren, this is ready for another look.

tldahlgren · 2021-10-18T17:34:34Z

Looks like the scr build failed. See https://cdash.spack.io/buildSummary.php?buildid=337976.

tldahlgren

Confirmed the sha256 for all new/modified versions.

Would appreciate insight into why the pipeline build (linked above) failed.

var/spack/repos/builtin/packages/er/package.py

tldahlgren · 2021-10-18T19:35:11Z

var/spack/repos/builtin/packages/er/package.py

+            if spec.satisfies('platform=cray'):
+                args.append(self.define('ER_LINK_STATIC', True))


So I understand, this option does not need to be set if the build occurs on a cray for version 0.1.0 on?

That is correct as these <name>_LINK_STATIC options are no longer exposed to the user in latest version as this is one thing ~shared will enable automatically.

Now, whether ~shared is now needed for cray, I don't have a solid answer, but I don't think so. A recent update was made to the scr package to disable this by default, even on cray, so this might true for the components as well, but we haven't been able to test on a cray system as of yet (hopefully soon, whereafter adjustments might need to be made).
Note: The scr package will be getting updated with the shared variant soon as well.

@gonsie will likely have better insight on this.

var/spack/repos/builtin/packages/rankstr/package.py

Lock dependencies for [email protected] to the versions released at the same time.

CamStan · 2021-10-20T00:18:54Z

Would appreciate insight into why the pipeline build (linked above) failed.

The latest version of axl removed support for a particular async interface (CPPR),
ECP-VeloC/AXL@1afef9a#diff-b8ab8c9a715f1fed4fec1206c88b3c33cf0ba2df394cf2f00d43ac2a673d3674

but [email protected] still attempts to reference it
https://github.com/LLNL/scr/blob/5273576b2836b1990a6771bb1e1ddd5fdc1a4eec/src/scr_util_mpi.c#L310

I added the scr package to this PR to simply lock in dependency versions for [email protected] to the component versions released at the same time, so this should pass now. 🤞
A bigger update to the scr package is coming soon where I'll do the same for the [email protected] release with these component releases.

spackbot-app bot added dependencies new-variant new-version update-package labels Oct 13, 2021

spackbot-app bot added the maintainers label Oct 13, 2021

tldahlgren requested changes Oct 13, 2021

View reviewed changes

tldahlgren self-assigned this Oct 13, 2021

CamStan force-pushed the scr_components_releases branch from db70dcf to b15c6af Compare October 15, 2021 19:04

tldahlgren reviewed Oct 18, 2021

View reviewed changes

Fix scr build error

3b5d166

Lock dependencies for [email protected] to the versions released at the same time.

CamStan requested a review from tldahlgren October 20, 2021 00:38

tldahlgren approved these changes Oct 22, 2021

View reviewed changes

tldahlgren merged commit 8b8bec2 into spack:develop Oct 22, 2021

CamStan deleted the scr_components_releases branch October 25, 2021 16:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scr/veloc: component releases#26716

scr/veloc: component releases#26716
tldahlgren merged 2 commits intospack:developfrom
CamStan:scr_components_releases

CamStan commented Oct 13, 2021 •

edited

Loading

Uh oh!

spackbot-app bot commented Oct 13, 2021

Uh oh!

CamStan commented Oct 13, 2021

Uh oh!

tldahlgren left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CamStan commented Oct 15, 2021

Uh oh!

tldahlgren commented Oct 18, 2021

Uh oh!

tldahlgren left a comment •

edited

Loading

Uh oh!

Uh oh!

tldahlgren Oct 18, 2021

Uh oh!

CamStan Oct 19, 2021 •

edited

Loading

Uh oh!

Uh oh!

CamStan commented Oct 20, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if spec.satisfies('platform=cray'):
		args.append(self.define('ER_LINK_STATIC', True))

Conversation

CamStan commented Oct 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update

Uh oh!

spackbot-app bot commented Oct 13, 2021

Uh oh!

CamStan commented Oct 13, 2021

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CamStan commented Oct 15, 2021

Uh oh!

tldahlgren commented Oct 18, 2021

Uh oh!

tldahlgren left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tldahlgren Oct 18, 2021

Choose a reason for hiding this comment

Uh oh!

CamStan Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CamStan commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CamStan commented Oct 13, 2021 •

edited

Loading

tldahlgren left a comment •

edited

Loading

CamStan Oct 19, 2021 •

edited

Loading

CamStan commented Oct 20, 2021 •

edited

Loading