Python: use platform-specific site packages dir#25998
Merged
tldahlgren merged 1 commit intospack:developfrom Sep 19, 2021
Merged
Python: use platform-specific site packages dir#25998tldahlgren merged 1 commit intospack:developfrom
tldahlgren merged 1 commit intospack:developfrom
Conversation
tldahlgren
approved these changes
Sep 16, 2021
Contributor
|
Deferring merge until Adam receives the requested feedback. |
Contributor
|
@adamjstewart and @tldahlgren this patch fixes my problem! Thank you! I tested all of the python packages that I use regularly which includes py-cython, py-toml, py-setuptools, py-numcodecs, py-numpy, and some compressor packages that I use and maintain. |
4 tasks
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is yet another follow-up to #24095.
On most systems that I've tested, the platform-dependent and platform-independent site packages directories are the same. However, in #25973, @robertu94 discovered that on his system, this is not the case. During installation, we pass both
--install-pureliband--install-platlib, and Cython chooses to install toplatlibinstead ofpurelib. I see two possibilities:platliband we should always addplatlibto thePYTHONPATH(done in this PR)platlibtopurelibdepending on the package and we need to add both to thePYTHONPATH@robertu94 can you test this and see if it introduces more bugs than it fixes? I'm also hoping GitLab will catch any potential issues as it builds a decently sized Python stack.