Add a __reduce__ method to Environment#25678
Merged
tgamblin merged 3 commits intospack:developfrom Sep 15, 2021
Merged
Conversation
adamjstewart
added
environments
bugfix
tgamblin
approved these changes
Sep 15, 2021
haampie
pushed a commit
to haampie/spack
that referenced
this pull request
Sep 17, 2021
* Add a __reduce__ method to Environment * Add unit test * Convert Path to str
haampie
pushed a commit
to haampie/spack
that referenced
this pull request
Sep 17, 2021
* Add a __reduce__ method to Environment * Add unit test * Convert Path to str
haampie
added a commit
to haampie/spack
that referenced
this pull request
Sep 17, 2021
This reverts commit 110343a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
__reduce__method tospack.environment.Environment. Without this, we hit the maximum recursion limit when trying to pickleEnvironmentobjects.Fixes #20025. This PR is very similar in spirit to #25658, which fixed #23892.
This PR was just the bare minimum needed to fix the issue. I have no idea if I implemented
__reduce__correctly or not...Also, I would really like to avoid catching
BaseExceptioninspack.install_test.TestSuite.__call__so that this kind of issue would be easier to diagnose in the future. On develop,spack test rundoesn't raise any exception and silently doesn't do anything.