I think as we add the binary bootstrapping PR we should update this to include tests for bootstrapping from binaries.

@adamjstewart I think this is ready for a review. It's not perfect, but I'd rather merge this as is, if you don't see any big issue, and work later on simplifying the site_packages_dir etc. machinery. With this at least we'll fix the issues with bootstrapping clingo from sources.

It's not perfect, but I'd rather merge this as is, if you don't see any big issue, and work later on simplifying the site_packages_dir etc. machinery.

I'm a little wary of a quick fix that could potentially break other packages. What if we instead compute this in bootstrap.py instead of in the base class and come up with a more robust solution later? That solves the clingo problem and doesn't change the API until we figure out a more robust way for site_packages_dir to be overridden.

What if we instead compute this in bootstrap.py instead of in the base class and come up with a more robust solution later? That solves the clingo problem and doesn't change the API until we figure out a more robust way for site_packages_dir to be overridden.

We can do that, but it means undoing #24095 in bootstrap.py. Note that we don't bootstrap only clingo but also Python packages needed for e.g. spack style and those are working.

@adamjstewart @tgamblin This is ready to be reviewed and merged if there are no issues

Thanks @adamjstewart