make --enable-locks actually enable locks#24675
Merged
haampie merged 1 commit intospack:developfrom Nov 9, 2021
Merged
Conversation
Contributor
|
@tgamblin Added you as reviewer since you were the last one to touch the modified code. |
Contributor
Author
|
Just rebasing to retrigger checks. I don't think the failures are related to my changes (and if they are, that may suggest some deeper problem running CI with locks). |
haampie
approved these changes
Nov 9, 2021
Member
haampie
left a comment
haampie
left a comment
There was a problem hiding this comment.
Not sure why this was never merged, thanks!
haampie
pushed a commit
to haampie/spack
that referenced
this pull request
Nov 9, 2021
haampie
pushed a commit
that referenced
this pull request
Nov 16, 2021
alalazo
pushed a commit
that referenced
this pull request
Dec 23, 2021
capitalaslash
pushed a commit
to capitalaslash/spack
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of disabling them. (I won't admit how much time this cost me.)