Skip to content

Add first version of real cdash logging#2445

Closed
hegner wants to merge 6 commits intospack:developfrom
hegner:features/cdashreport
Closed

Add first version of real cdash logging#2445
hegner wants to merge 6 commits intospack:developfrom
hegner:features/cdashreport

Conversation

@hegner
Copy link
Copy Markdown

@hegner hegner commented Nov 30, 2016

I implemented some explicit CDash reporting as a new config option for --log-format. Unfortunately I had to create 3 independent files for the configure, build, test steps. The actual content to upload is not entirely clear to me yet, thus a few TODO's scattered around the code still.

@alalazo @tgamblin - ping

@hegner
Copy link
Copy Markdown
Author

hegner commented Nov 30, 2016

Essential pieces done for now. There is one cdash bug I couldn't resolve yet - the upload order of the created xml files counts. the build one has to come first. There must be some implicit assumption in CDash I am violating/not aware of.

Depending on which direction you'd like to go I could factor the junit and cdash features out of install.py and put it into e.g. lib/spack/spack/dashboards.py

@hegner hegner changed the title [WIP] Add first version of real cdash logging Add first version of real cdash logging Nov 30, 2016
@hegner
Copy link
Copy Markdown
Author

hegner commented Nov 30, 2016

@tgamblin - what would be a good section in the docs for that feature?

@tgamblin
Copy link
Copy Markdown
Member

@hegner: what if we add a new top-level section on testing? I think there will end up being a lot of stuff in this section.

@hegner
Copy link
Copy Markdown
Author

hegner commented Nov 30, 2016

@tgamblin - sounds good. It may have quite an overlap with the contribution guide though.

@tgamblin
Copy link
Copy Markdown
Member

@hegner: I was thinking about that. I think the sections in the contribution guide on testing could be moved into a common testing section in the reference guide, then cross-referenced from where they are now.

@adamjstewart: what do you think?

@adamjstewart
Copy link
Copy Markdown
Member

I don't know much about this, but it seems different than the Contribution Guide. The Contribution Guide is everything you need to know to contribute code to Spack. This seems like it's for release testing. I would be fine with that going under a new top-level section.

Depending on which direction you'd like to go I could factor the junit and cdash features out of install.py and put it into e.g. lib/spack/spack/dashboards.py

Maybe that's something that would go under lib/spack/spack/hooks?

@hegner
Copy link
Copy Markdown
Author

hegner commented Nov 30, 2016

@adamjstewart - those look like build hooks, which serve a slightly different purpose.

@hegner
Copy link
Copy Markdown
Author

hegner commented Nov 30, 2016

@tgamblin - preliminary docs are there now. I'd be delighted if someone could give it an independent try on our cdash instance.

@hegner
Copy link
Copy Markdown
Author

hegner commented Dec 3, 2016

Refactored into place @adamjstewart suggested.

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Jan 5, 2017

Hi all - we now have cdash set up at https://spack.io/cdash. So we can start getting this set up.

@kielfriedt has a YAML test suite format set up, so once that is done we can start having sites run tests of their choosing, and submit results to CDash.

@davydden
Copy link
Copy Markdown
Member

@hegner could you please resolve the merge conflict?

@tgamblin
Copy link
Copy Markdown
Member

This is superseded by (and included in) #2917.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants