New modulecmd detection algorithm.#2426
Closed
skosukhin wants to merge 1 commit intospack:developfrom
Closed
Conversation
skosukhin
force-pushed
the
pr_modulecmd
branch
from
81b25ee to
ffaae70
Compare
skosukhin
force-pushed
the
pr_modulecmd
branch
from
ffaae70 to
7a1ceb3
Compare
Member
|
@skosukhin any reason why this was closed? It's pretty useful |
Member
Author
|
@mamelara I've closed this because we can't be sure that the executable called by the 'module' shell function is actually what we expect it to be. I've stumbled upon a very strange configuration of the Environment Modules where the 'module' shell function called not 'modulecmd' but some additional wrapping script, which acted differently. So, to make thing simple and straightforward I decided that it was much better just to let users know that they need to add 'modulecmd' executable to the PATH and it was up to them to make sure that it was the 'right' one. |
16 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes modulecmd is not in the PATH and the only way to find it is to parse the corresponding shell function. This is what this PR offers.