Allow spack create to handle packages with period in name#2351
Allow spack create to handle packages with period in name#2351tgamblin merged 2 commits intospack:developfrom
Conversation
|
@alalazo @tgamblin Another random Travis failure. Seems to be getting more frequent lately. |
|
@adamjstewart Is there an issue open on those random failures ? If not can you open it and link at least the PRs where it happened ? I think it would be good to see if the causes are always the same. In this case it seems something related to the fetchers. |
|
@alalazo How do I look up the URL for the Travis build that failed? |
|
If people didn't force push, I guess you can just click on the |
|
It looks like even if you close and reopen, it overwrites the |
|
Ping @tgamblin |
|
This looks good to me, but @tgamblin is more familiar with the namespace feature so I'll probably leave it until he gets a chance to look at it. |
|
@becker33: this isn't actually about namespaces, just packages that have @adamjstewart: This looks good, I'm just curious whether you think it would be better to handle the conversion of |
|
@tgamblin I'll leave it up to you. I'm not sure what the original tarball name would be useful for, but you're welcome to push any changes to my branch. My only request is that my changes to the |
|
Ok I thought about this more. I actually like the consistency and don't feel like adding a special case we're not likely to use. |
* Allow spack create to handle packages with period in name * Update tests to handle new package name detection scheme
Fixes #2346.
Some package URLs include a period in their name, such as:
When running
spack create, this was being interpreted as a package name ofssl_match_hostnameand a NAMESPACE ofbackports. This PR replaces periods and underscores with dashes, so as to match the rest of Spack. I've never used Spack's NAMESPACE support, so can someone who does test this PR for me?If anyone wants me to, I can rename packages like
the_silver_searcherandSAMRAIto be lowercase and separated by dashes. And then we can get into the debate overRvs.r😄