Conversation
| depends_on('py-certifi') | ||
| depends_on('py-backports-abc', when='^python@:2') | ||
| depends_on('py-singledispatch', when='^python@:2') | ||
| depends_on('py-futures', when='+futures^python@:2') |
There was a problem hiding this comment.
i am not sure, but the :2 could be [...,2), i.e. not including 2. whereas @2: is including 2, i.e. [2,...).
There was a problem hiding this comment.
Ranges are inclusive, so this is correct.
| # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
| ############################################################################## | ||
| # | ||
| # This is a template package file for Spack. We've put "FIXME" |
There was a problem hiding this comment.
i guess you forgot to remove these
|
|
||
|
|
||
| class PyFutures(Package): | ||
| """FIXME: Put a proper description of your package here.""" |
| class PyFutures(Package): | ||
| """FIXME: Put a proper description of your package here.""" | ||
|
|
||
| # FIXME: Add a proper url for your package's homepage here. |
| # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
| ############################################################################## | ||
| # | ||
| # This is a template package file for Spack. We've put "FIXME" |
|
|
||
|
|
||
| class PyMonotonic(Package): | ||
| """FIXME: Put a proper description of your package here.""" |
| class PyMonotonic(Package): | ||
| """FIXME: Put a proper description of your package here.""" | ||
|
|
||
| # FIXME: Add a proper url for your package's homepage here. |
| # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
| ############################################################################## | ||
| # | ||
| # This is a template package file for Spack. We've put "FIXME" |
|
|
||
|
|
||
| class PySingledispatch(Package): | ||
| """FIXME: Put a proper description of your package here.""" |
| class PySingledispatch(Package): | ||
| """FIXME: Put a proper description of your package here.""" | ||
|
|
||
| # FIXME: Add a proper url for your package's homepage here. |
|
i edited the title, feel free to adjust it if needed. |
| extends('python') | ||
| depends_on('py-setuptools', type='build') | ||
| depends_on('py-vcversioner') | ||
| depends_on('py-functools32') |
There was a problem hiding this comment.
There are a couple other optional dependencies that could be added, but I'm not sure if it really matters:
extras_require = {
"format" : ["rfc3987", "strict-rfc3339", "webcolors"],
":python_version=='2.6'": ["argparse", "repoze.lru"],
":python_version=='2.7'": ["functools32"],
}|
|
||
| extends('python') | ||
| depends_on('py-setuptools', type='build') | ||
| depends_on('curl') |
There was a problem hiding this comment.
If you want to be more specific about the dependency versions, they are:
Requirements
------------
- Python 2.6, 2.7 or 3.1 through 3.5.
- libcurl 7.19.0 or better.
| extends('python') | ||
|
|
||
| depends_on('py-setuptools', type='build') | ||
| depends_on('py-six') |
There was a problem hiding this comment.
py-ordereddict is also required for Python versions less than 2.7.
| depends_on('py-futures', when='+futures^python@:2') | ||
| depends_on('py-monotonic', when='+monotonic^python@:2') | ||
| depends_on('py-pycurl', when='+curl') | ||
| depends_on('py-twisted', when='+twisted') |
There was a problem hiding this comment.
The setup.py doesn't mention integrating with py-futures through py-twisted. Where do they come from?
There was a problem hiding this comment.
I added those since they're listed as optional dependencies in the Arch py-tornado package. I'm looking into it.
There was a problem hiding this comment.
If you look at this page: http://www.tornadoweb.org/en/stable/index.html They list these packages under prerequisites as 'optional'. I'll leave them off for now since I just want to get things working.
| depends_on('py-setuptools', type='build') | ||
| depends_on('py-certifi') | ||
| depends_on('py-backports-abc', when='^python@:2') | ||
| depends_on('py-singledispatch', when='^python@:2') |
There was a problem hiding this comment.
[email protected]: is needed for Python < 3.5
py-singledispatch and py-certifi are needed for Python < 3.4
py-ordereddict is needed for Python < 2.7
py-backports is needed for Python < 2.7.9
See setup.py for details.
There was a problem hiding this comment.
Corrected this in d5ed437, Also added backports.ssl_match_hostname.
|
|
||
| extends('python') | ||
| depends_on('py-setuptools', type='build') | ||
| depends_on('py-cython') |
|
|
||
| # FIXME: Add a proper url for your package's homepage here. | ||
| homepage = "http://www.example.com" | ||
| url = "https://pypi.python.org/packages/55/db/97c1ca37edab586a1ae03d6892b6633d8eaa23b23ac40c7e5bbc55423c78/futures-3.0.5.tar.gz" |
There was a problem hiding this comment.
For url's like this where the PyPi link contains the hash of the package, things like spack versions and spack checksum won't work. Can you try out the pypi.io link format suggested in #1939 (comment)?
There was a problem hiding this comment.
I've corrected all of the packages I've added. However, there are a number of other packages which need this as well, and there's still the issue of #2335.
|
@adamjstewart @davydden I will work on all of these issues, however the purpose of this branch is to show the |
|
@krafczyk i would say it's better to keep everything in one branch and since @adamjstewart already commented a lot, it would be easier if you just push your changes here. I don't see a reason for another branch with the same content. |
8ade5b2 to
2d5aa0c
Compare
|
@krafczyk : looking at commits, something is wrong here (same commits have different hashes and are duplicated). I suggest you (i) reset your local branch to 7d18593; (ii) rebase on top of current develop in Spack (don't forget ot fetch it or pull it if it's your local copy); (iii) cherry-pick 3f0a6e1 and 3bf1d9b. This should give you a clean local branch. If all looks good, you can then |
15ffe16 to
a111742
Compare
|
@davydden : I've done what you suggested. I'll pay closer attention next time. |
|
@krafczyk thanks, looks nice now 👍 |
|
@adamjstewart, @davydden, @citibeth, @jppelteret: I've nearly finished adding everything necessary for the jupyter-notebook to work. Now I'm running into a strange problem having to do with npm. Since I'm not that familiar with npm, perhaps one of you can help me out here. When I try to install py-jupyter_notebook from 0d36e3d, I get the output located at this pastebin: http://pastebin.com/rt1Ghv4Z The log file from the build is at this pastebin: http://pastebin.com/fZR4a8z1 So, while the correct node is used along with the correct npm, I'm getting weird access errors, and npm is trying to write to my home directory. I would think ideally that anything npm installs ought to belong to the py-jupyter_notebook prefix. I'm not sure how to make that happen though. |
|
Sigh, yet another package manager with its own ideas of how to do things
|
|
Is there a way to set environment variables when installing or using a specific package? |
|
@krafczyk: See the section on |
|
@krafczyk you can also set environment by |
|
Great! |
|
@krafczyk: note that if you modify There is perhaps better documentation on this in the module configuration section. |
| url = "https://github.com/westes/flex/releases/download/v2.6.2/flex-2.6.2.tar.gz" | ||
|
|
||
| version('2.6.0', '5724bcffed4ebe39e9b55a9be80859ec') | ||
| version('2.5.39', 'e133e9ead8ec0a58d81166b461244fde') |
There was a problem hiding this comment.
why removing 2.5.39 and 2.6.0 ? 2.5.39 is need by foam-extend, for example. Removing versions is generally not a good idea.
btw, the old download works fine for me (i checked 2.5.39). Also if that is not needed for python packages, then please create a separate PR for this change.
There was a problem hiding this comment.
Sorry about that, I've fixed up flex good and proper this time.
The reason I did that was because I was running into a segfault when building binutils and moving to the latest version of flex (2.6.2) seemed to solve the problem. In addition, flex development has moved to github so It would be good to reflect that change. The md5s have all been updated.
There was a problem hiding this comment.
binutils is part of the dependency chain for yt which was my ultimate goal for using jupyter-notebook.
|
I'd like to announce that jupyter-notebook is now working as expected for me! It took a lot of work, but now I'm able to use yt in jupyter-notebook! About the npm problem, it turns out that npm was trying to write to the 'cache' which was set to ~/.npm. This can be overridden with the environment variable npm_config_cache, so I've set this to the npm prefix. This means that all npm downloads will go into npm's prefix. This is a kludgy fix, but it seems to work for now. There are quite a few commits, so I'd like comments from folks. |
|
The npm thing means that npm downloads cannot be versioned independently of On Fri, Nov 18, 2016 at 7:52 PM, Matthew Scott Krafczyk <
|
|
I believe it will be squashed when it's merged.
…On Thu, Jan 5, 2017 at 12:30 PM, Matthew Scott Krafczyk < ***@***.***> wrote:
@davydden <https://github.com/davydden>: I've removed the FIXME's you
mentioned
@adamjstewart <https://github.com/adamjstewart>: I've fixed the grammar
issues you raised as well as changed the package names you mentioned.
Do you guys think I should squash all these changes into one commit? as it
stands there are almost 100 commits of work here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2320 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB1cd7r7bN2nExIAJyhEeIWQrX5UiU4hks5rPSiigaJpZM4Kwek5>
.
|
| @@ -0,0 +1,42 @@ | |||
| ############################################################################## | |||
There was a problem hiding this comment.
This one still needs to be renamed.
| stdout=subprocess.PIPE) | ||
| result_which = process_pipe.communicate()[0] | ||
| process_pipe = subprocess.Popen(["whereis", "libtool"], | ||
| stdout=subprocess.PIPE) |
There was a problem hiding this comment.
You ought to be able to use which('libtool'), but I'm fine with merging this as is.
|
|
||
| depends_on('py-setuptools', type='build') | ||
| depends_on('[email protected]:2.7.999,3.3:') | ||
| depends_on('[email protected]:') |
|
I would not squash it even during the merge as commits have different authorship |
|
@adamjstewart: approve? |
|
@tgamblin, I did not know that you could make a commit on my fork without me pulling it. Nifty! |
|
@krafczyk: There's a checkbox for this when you commit the PR -- it's the allow edits by maintainers one. |
Adds the following packages: node-js py-backports-abc py-functools32 py-pycurl py-vcversione npm py-certifi py-jsonschema py-tornado py-zmq - Added python packages that are dependencies for the Jupyter suite - Update new python packaages to use extension package install function. - Added npm and node-js packages
This adds the following packages: py-backports-shutil-get-terminal-size py-nbformat py-backports-ssl-match-hostname py-pathlib2 py-entrypoints py-pickleshare py-futures py-pip py-ipykernel py-prompt-toolkit py-ipython-genutils py-ptyprocess py-ipywidgets py-simplegeneric py-jupyter-client py-singledispatch py-jupyter-console py-terminado py-jupyter-core py-traitlets py-jupyter-notebook py-wcwidth py-monotonic py-widgetsnbextension py-nbconvert
b6edd93 to
126a115
Compare
|
I squashed this into two commits by @jppelteret and @krafczyk. They now list the added packages: @krafczyk: if the tests pass and you're ok with this we can merge. |
|
@tgamblin I'm testing that things still work for me as I expect. I'll let you know in a bit. |
|
@krafczyk: Sounds good. If you need to revert, the tip before rebasing was b6edd93. The only diff between that and the two squashed commits above is that the squashed ones are based on $ git co fix/when_variants_plus_dependency
Switched to branch 'fix/when_variants_plus_dependency'
Your branch is up-to-date with 'krafczyk/fix/when_variants_plus_dependency'.
$ git diff b6edd93
diff --git a/lib/spack/spack/test/conftest.py b/lib/spack/spack/test/conftest.py
index 11127d8..79d9018 100644
--- a/lib/spack/spack/test/conftest.py
+++ b/lib/spack/spack/test/conftest.py
@@ -122,7 +122,6 @@ def builtin_mock(repo_path):
def refresh_builtin_mock(builtin_mock, repo_path):
"""Refreshes the state of spack.repo"""
# Get back the real repository
- spack.repo.swap(builtin_mock.real)
mock_repo = copy.deepcopy(repo_path)
spack.repo.swap(mock_repo)
return builtin_mock |
|
@tgamblin: Everything looks good to me. You can merge when the tests are finished. |
|
@adamjstewart It's the set-up phase that seems to take a lot (e.g |
|
@tgamblin tests are done, ready to merge |
|
@krafczyk: merged! Thanks a lot to you and @jppelteret! |
This branch contains a version of the package py-tornado which exposes the problem with the when clauses discussed in #2310.