Skip to content

scotch: adding dependencies + variants for mpi, shared, compression and esmumps#231

Merged
tgamblin merged 3 commits intospack:developfrom
epfl-scitas:packages/scotch
Dec 20, 2015
Merged

scotch: adding dependencies + variants for mpi, shared, compression and esmumps#231
tgamblin merged 3 commits intospack:developfrom
epfl-scitas:packages/scotch

Conversation

@nrichart
Copy link
Copy Markdown
Contributor

This PR adds dependencies to flex and bison and compression from the package already on spack.
The flex and bison dependencies are only for compilation and the makefiles have a fallback to pre-generated files so these dependencies could perhaps been removed.
The zlib dependency is configurable with a variant compression

It also permits to build shared libraries
What should be the default static or shared ? For now I put the default as shared since it works better with the rpath strategy in spack.

The dependency to mpi add the library pt-scotch so I made it a variant. In addition to esmumps that was not there.

I did not change the install strategy used in the package. But it also installs also a metis.h file that goes with libscotchmetis and could interfere with the package metis, if both module are loaded at the same time.

@tgamblin
Copy link
Copy Markdown
Member

@nrichart: Thanks! I think the default should be shared.

Can the things in write_make_inc() be put into a patch function? The patch() function guarantees that make.inc only gets written once -- even if you run install() more than once. Or do you want write_make_inc() to execute every time? It's usually useful for debugging if modifications only happen once in patch, because then you can tweak them and test changes if the build fails the first time.

@tgamblin tgamblin self-assigned this Dec 20, 2015
@nrichart
Copy link
Copy Markdown
Contributor Author

@tgamblin there was no particular reason not to have in a patch function. I moved the contain of the write_make_inc in a patch function.

@tgamblin
Copy link
Copy Markdown
Member

Thanks!

tgamblin added a commit that referenced this pull request Dec 20, 2015
scotch: adding dependencies + variants for mpi, shared, compression and esmumps
@tgamblin tgamblin merged commit bb329d8 into spack:develop Dec 20, 2015
@nrichart nrichart deleted the packages/scotch branch January 20, 2016 17:40
gartung pushed a commit that referenced this pull request Feb 28, 2019
* Added the `spack buildcache preview` sub-command

This is similar to `spack spec -I` but highlights which nodes in a DAG
are relocatable and which are not.

spec.tree has been generalized a little to accept a status function,
instead of always showing the install status

The current implementation works only for ELF, and needs to be
generalized to other platforms.

* Added a test to check if an executable is relocatable or not

This test requires a few commands to be present in the environment.
Currently it will run only under python 3.7 (which uses Xenial instead
of Trusty).

* Added tests for the 'buildcache preview' command.

* Fixed codebase after rebase

* Fixed the list of apt addons for Python 3.7 in travis.yaml

* Only check ELF executables and shared libraries. Skip checking virtual or external packages. (#229)

* Fixed flake8 issues

* Add handling for macOS mach binaries (#231)
matz-e pushed a commit to matz-e/spack that referenced this pull request Apr 27, 2020
climbfuji added a commit to climbfuji/spack that referenced this pull request Feb 25, 2023
Updates required for creating binary (build) caches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants