Fix unit tests mutating the system#22921
Closed
haampie wants to merge 12 commits intospack:developfrom
Closed
Conversation
6ab76e5 to
fa697c6
Compare
Member
Author
|
Currently: |
Member
Author
|
Oh, I forgot to set and |
Member
Author
|
Okay, this seems done. All relevant tests pass now! The 2 errors are:
Can I somehow mark those a skipped when the spack root folder is readonly? |
This reverts commit 5e6b469. Seems like this wasn't necessary at all
Member
Author
|
I don't really feel like rebasing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bunch of fixes needed to make most of the tests pass on a readonly filesystem.
Ping @becker33 / @alalazo.
Closes #22920