Merged
Conversation
Member
becker33
pushed a commit
that referenced
this pull request
Nov 22, 2016
* fix bug in search for concrete compiler * simplify implementation of concretize_compiler * fix flake8 errors
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Nov 28, 2022
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs warning spack#2196: routine is both "inline" and "noinline" cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference.
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Jan 3, 2023
Tagging @alalazo and @rschon2 The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs warning spack#2196: routine is both "inline" and "noinline" cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167
alalazo
pushed a commit
that referenced
this pull request
Jan 5, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning #2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of #34167 Co-authored-by: Stephen Sachs <[email protected]>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 24, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning spack#2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167 Co-authored-by: Stephen Sachs <[email protected]>
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning spack#2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167 Co-authored-by: Stephen Sachs <[email protected]>
techxdave
pushed a commit
to Tech-XCorp/spack
that referenced
this pull request
Feb 17, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning spack#2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167 Co-authored-by: Stephen Sachs <[email protected]>
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
The Intel compiler isn't able to deal with noinline member functions of template classses defined in headers. As such it outputs ``` warning spack#2196: routine is both "inline" and "noinline" ``` cmake bootstrap will fail due to the word 'warning'. See spack/var/spack/repos/builtin/packages/protobuf/intel-v2.patch for reference. The issue does not appear with [email protected] or later: ``` $~: compiler=/shared/spack/opt/spack/linux-amzn2-x86_64_v3/gcc-12.2.0/intel-oneapi-compilers-2022.2.0-uqvb2553zy5toeapvoopacndd27x6p5m/compiler/2022.2.0/linux/bin/intel64/icpc $~: $compiler unique.c icpc: remark spack#10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message. ``` This is a clean version of spack#34167 Co-authored-by: Stephen Sachs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop at
lib/spack/spack/concretize.py:389was not checking all of the elements in the list.