HIP: document variables, apply patches to older versions, fix build issues#21852
Merged
alalazo merged 6 commits intospack:developfrom Feb 24, 2021
Merged
Conversation
haampie
force-pushed
the
feature/document-hip-variables-better
branch
from
c1eb1f6 to
dfd2194
Compare
Member
Author
|
Also pinging @srekolam |
Member
Author
|
Ok, I've also fixed the situation with rocm 3.8.0 a hair: |
haampie
changed the title
haampie
force-pushed
the
feature/document-hip-variables-better
branch
from
09ab499 to
74f8f10
Compare
srekolam
reviewed
Feb 22, 2021
Member
Author
|
I'm building the following: spack:
view: false
specs:
- matrix:
- [sirius@develop+rocm ^openmpi ^openblas threads=openmp arch=linux-centos8-zen]
- [^[email protected], ^[email protected], ^[email protected], ^[email protected], ^[email protected]]
packages:
all:
variants: amdgpu_target=gfx906 tensile_architecture=gfx906only waiting for 3.7.0 to finish, but the rest works fine. |
Member
Author
|
My packages build fine with 3.7, 3.8, 3.9, 3.10 and 4.0 (which include rocblas & rocfft). Only 3.5 does not work because because it is missing that patch for the shared lib name, but that was the case from the beginning. So this PR is ready for review now |
Contributor
|
@haampie Any idea on when this PR will merge? |
Member
Author
|
As soon as @srekolam agrees with it, so soon (tm) |
alalazo
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there are many variables being set I thought it would be a good idea to document them better and slightly simplify the logic for external vs not-external.
Supersedes #21822 ping @bvanessen