Skip to content

WarpX: CMake#21787

Merged
ax3l merged 3 commits intospack:developfrom
ax3l:topic-warpXcmake
Feb 25, 2021
Merged

WarpX: CMake#21787
ax3l merged 3 commits intospack:developfrom
ax3l:topic-warpXcmake

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented Feb 19, 2021 •
edited
Loading

This transitions the WarpX package to use its new CMake build logic.

Introduces packages:

According to my tests, this should also fix the installation errors that we currently observe in nightly setup tests: https://dev.azure.com/ECP-WarpX/WarpX/_build/results?buildId=1529&view=results

Requires #21770 to build by workaround-free with RZ geometry.

I'll start introducing fixed versions after the next major release, so long we build from development.

cc @dpgrote @RemiLehe

@ax3l ax3l mentioned this pull request Feb 19, 2021
Merged
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Feb 19, 2021

It seems there are missing dependencies in this recipe

@ax3l
Copy link
Copy Markdown
Member Author

ax3l commented Feb 19, 2021 •
edited
Loading

with clingo, I also get an ==> Error: 'pic' for spack solve warpx. Do you know what that means? I checked through +/~pic variants in dependencies and could not spot one causing this (I commented out the variants).

Installs worked, but will see what comes up and what I missed.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Feb 19, 2021

I'll have a look at the error with clingo

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Feb 19, 2021

@ax3l We definitely need better error reporting, but the new concretizer caught errors in the directives for vtk-m (and maybe other packages that may be transitive dependencies, I'm checking right now). The issue is that they reference in conflicts or depends_on directives variants that have never been declared. For instance in vtk-m there is:

conflicts("~shared", when="~pic")

but the pic variant has never been declared.

@alalazo alalazo mentioned this pull request Feb 19, 2021
Merged
@ax3l ax3l force-pushed the topic-warpXcmake branch 2 times, most recently from 50707d6 to 61f9cb1 Compare February 19, 2021 22:47
@ax3l ax3l mentioned this pull request Feb 19, 2021
Merged
2 tasks
@ax3l ax3l mentioned this pull request Feb 23, 2021
Merged
1 task
@ax3l
Copy link
Copy Markdown
Member Author

ax3l commented Feb 24, 2021

ping @dpgrote @RemiLehe :)

@ax3l
Copy link
Copy Markdown
Member Author

ax3l commented Feb 25, 2021

@alalazo since my co-maintainers are busy and I am also maintainer of the package, can you review and approve it, please? :)

@ax3l ax3l added the ecp label Feb 25, 2021
dpgrote
dpgrote approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dpgrote dpgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are good.

@ax3l ax3l enabled auto-merge (squash) February 25, 2021 18:42
@ax3l ax3l requested review from adamjstewart and alalazo February 25, 2021 18:42
@ax3l ax3l merged commit d05e0df into spack:develop Feb 25, 2021
@ax3l ax3l deleted the topic-warpXcmake branch February 25, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

@adamjstewart adamjstewart Awaiting requested review from adamjstewart

+1 more reviewer

@dpgrote dpgrote dpgrote approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ecp new-package update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ax3l @alalazo @dpgrote