Delete unused "mutable_mock_store" fixture#21632
Merged
tgamblin merged 1 commit intospack:developfrom Feb 17, 2021
Merged
Conversation
The fixture was introduced in spack#19690 maybe accidentally. It's not used in unit tests, and though it should be mutable it seems an exact copy of it's immutable version.
alalazo
added
ci
Member
Author
Contributor
|
@alalazo Thanks for spotting this. I am okay with getting rid of it. This was going to be used for test_update_sbang in bindist.py. Unfortunately I determined that this test case requires such a specific and unique set of operations that this fixture would not have been of much use to it. |
tgamblin
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixture was introduced in #19690, maybe accidentally. It's not used in unit tests, and though it should be mutable it seems an exact copy of it's immutable version.