Removes cyclic dependency on spack.config.#2121
Merged
tgamblin merged 1 commit intospack:developfrom Oct 31, 2016
Merged
Conversation
tgamblin
requested changes
Oct 25, 2016
Member
tgamblin
left a comment
tgamblin
left a comment
There was a problem hiding this comment.
LGTM. Can you fix the flake8 issues?
mpbelhorn
force-pushed
the
cray_platform_hotfix
branch
from
d8e381d to
8c11916
Compare
Merge spack#2030 added a cyclic dependency between the Cray platform needing to read a `targets.yaml` config file and `config.py` needing to get the platform names. This commit removes the cyclic dependency in favor of the more general config scheme. It also removes the now functionless `targets.yaml` config file. This breaks 'frontend' targets on the Cray platform but all architecture targets, including the frontend, that are provided by CrayPE are added to the Platform anyway so users can be explicit about the architecture targeted by the Cray compiler wrappers: ``` spack spec libelf arch=cray-CNL-frontend ``` becomes ``` spack spec libelf arch=cray-CNL-mc8 # on an XK7 or spack spec libelf arch=cray-CNL-sandybridge # on an older XC30, etc.. ``` The only way the 'frontend' target can be defined after this commit is through target environment variables.
mpbelhorn
force-pushed
the
cray_platform_hotfix
branch
from
8c11916 to
57e9d42
Compare
Contributor
Author
|
I have an optimization that puts the default modules and craype targets into a singleton which greatly improves performance. I can add it to this MR today if we want to hold of merging until then. |
tgamblin
approved these changes
Oct 31, 2016
Member
|
@mpbelhorn: sorry I missed your message a few days ago. Feel free to submit that whenever you want -- you may want to wait until after #2152 is merged as it affects configs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #2030 added a cyclic dependency between the Cray platform needing
to read a
targets.yamlconfig file andconfig.pyneeding to get theplatform names.
This commit removes the cyclic dependency in favor of the more general
config scheme. It also removes the now functionless
targets.yamlconfig file. This breaks 'frontend' targets on the Cray platform but
all architecture targets, including the frontend, that are provided by
CrayPE are added to the Platform anyway so users can be explicit about
the architecture targeted by the Cray compiler wrappers:
becomes
The only way the 'frontend' target can be defined after this commit is
through target environment variables.